Set stream protocol to HTTP 1.1 #219
Conversation
lib/tesla_api/stream.rb
Outdated
| def stream(endpoint: nil, &receiver) | ||
| endpoint ||= streaming_endpoint |
There was a problem hiding this comment.
This can just be the default value instead.
| def stream(endpoint: nil, &receiver) | |
| endpoint ||= streaming_endpoint | |
| def stream(endpoint: streaming_endpoint, &receiver) |
There was a problem hiding this comment.
Yeah – at the time there was a reason I didn't do it that way, but I can't think of it right now...
Likely, it was late and my mind wasn't on straight. In any case, changes made.
lib/tesla_api/stream.rb
Outdated
| private | ||
|
|
||
| TIMEOUT = 30 | ||
|
|
||
| def streaming_endpoint | ||
| Async::HTTP::Endpoint.parse(streaming_endpoint_url, alpn_protocols: Async::HTTP::Protocol::HTTP11.names) | ||
| end | ||
|
|
||
| private | ||
|
|
||
| TIMEOUT = 30 | ||
|
|
There was a problem hiding this comment.
This gets included on the Vehicle class, so I would rather it stays private.
There was a problem hiding this comment.
@timdorr yeah - I though it would be okay since it clarified itself as a streaming_endpoint.
I refactored it a bit and made both the url and endpoint values static members on the Stream module. I can easily duplicate this code as I'm configuring the proxy, but I'd rather pull the streaming url from the gem in case it ever changes.
This allows streams to run through a proxy server:
proxy_client = Async::HTTP::Client.new(Async::HTTP::Endpoint.parse("http://localhost:8888"))
original_endpoint = vehicle.streaming_endpoint
headers = { "proxy-authorization" => Protocol::HTTP::Header::Authorization.basic('username','password') }
proxy_client.proxied_endpoint(endpoint, headers)
cyu
force-pushed
the
cy/streaming-force-http11
branch
from
d2bea18 to
6314394
Compare
|
Great. |
|
I'll get this pushed out in a sec. |
Fixes issue #191
I also added a change to allow the endpoint to be configurable – this would allow me to proxy streams as well as the REST API.