Retry request on timeouts #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdorr
reviewed
Nov 13, 2019
|
I think this should be configurable so that users can turn it off if it doesn't suit their use-case. I handle these right now on my end so I can have more granular control over the recovery mechanism (immediate retry vs. backing out of some work completely). |
|
What do you think about making this off by default and allowing to configure (i.e. passing) Faraday's Retry options directly in the client initialization if needed? Kind of a drawback would be the "leaked" Faraday dependency though. |
|
I'm fine with folks knowing about Faraday. It's not a secret or anything. |
MarkusHarmsen
force-pushed
the
retry_requests
branch
from
ff06868 to
e9f6c2e
Compare
|
Ok, updated the pull request. |
|
Cool. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using this awesome gem, we discovered that sometimes API calls fail due to timeout/load related errors on Tesla's API side.
We especially recorded:
in maybe 1 in 100 calls.
This pull requests enables the Faraday retry feature and therefore retries any request up to 3 times with a pause of 0.5 seconds between each trial (increasing with a backoff factor 2), if the response code was one of the before mentioned codes.