Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update instructions #1

Merged
merged 1 commit into from
Nov 7, 2020
Merged

update instructions #1

merged 1 commit into from
Nov 7, 2020

Conversation

adamsitnik
Copy link
Contributor

while trying to repro dotnet/BenchmarkDotNet#1586 I've run into some issues with building the benchmarks...

I was surprised that git submodules are used instead of NuGet packages until I've hit Real-Serious-Games/C-Sharp-Promise#84 ;)

I think it would be nice to mention what is required to be able to build the benchmarks

@timcassell
Copy link
Owner

Heh yeah, those lengthy instructions are what I was trying to fix/avoid by referencing csprojs instead of dlls. But yes, those instructions with your change are the way to do it currently.

@timcassell timcassell merged commit a56d14a into timcassell:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants