Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #70: improve profile page #107

Merged
merged 3 commits into from
Aug 3, 2024
Merged

Closes #70: improve profile page #107

merged 3 commits into from
Aug 3, 2024

Conversation

manekenpix
Copy link
Member

Issue

Closes #70

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

This PR adds a few changes to the profile page:

  • responsiveness
  • user stats
  • uploading profile image.

Note
There's still a small issue with uploading a profile image. Images are usually successfully uploaded, but the profile page doesn't automagically refresh to display the uploaded image, so manual refresh is needed.
This issue will be addressed in a follow-up PR.

Testing the PR

  • Run migration on local BE
  • Run BE and FE
  • Assert that responsiveness, stats and uploading a profile image work as expected

Checklist

  • Quality: This PR builds and passes the respective npm run test and works locally
  • Tests: This PR includes thorough tests
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@manekenpix manekenpix added api API related issue web web related issue labels Aug 1, 2024
@manekenpix manekenpix requested a review from chrispinkney August 1, 2024 03:11
@manekenpix manekenpix self-assigned this Aug 1, 2024
@manekenpix manekenpix added this to the Frontend Restructuring milestone Aug 1, 2024
@chrispinkney
Copy link
Member

chrispinkney commented Aug 2, 2024

I tried to upload an avatar but it doesn't seem to be working, the /images/ route is giving me 404:

http://localhost:5173/user/eyJhbGciOiJIUzI1NiJ9.eyJhdWQiOiI1MzQ4ODRlODdkY2M0NmRkZmU2ZTg2MWY0NTM3NTk4OCIsInN1YiI6IjY1NWMxNTAwM2Q3NDU0MDExZTE5OTdlYiIsInNjb3BlcyI6WyJhcGlfcmVhZCJdLCJ2ZXJzaW9uIjoxfQ.Et7Tqkqh_-2r0WF-QVVFU6NW8wZuSwNh_7JENW25AMM/images/chrispinkney

404 Not Found

Did I do something wrong?

Stats seems to work tho which is awesome!

Copy link
Member

@chrispinkney chrispinkney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just this plus the above comment :)

@manekenpix manekenpix merged commit bec0bf5 into main Aug 3, 2024
@manekenpix manekenpix deleted the issue-70/user-page branch August 3, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api API related issue web web related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create user page
2 participants