Fix cell-change crash caused by use-after-free of BGSAttackDataMap #725
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assigned here during
TESNPC::Initialize()
TiltedEvolution/Code/client/Games/Forms.cpp
Lines 55 to 71 in 20b44d3
^ Notice how
attackDataMap
is taken from the PlayerCharacter singleton and assigned to a remote player's TESNPC. When that TESNPC unloads, the game (supposedly) tries to deallocate its resources, including this mapChanged raw pointer to a
NiPointer
which uses refcount, saving us from the crashPartially addresses #723 (0x140443C43 crash site)