engine: updateMode=synclet only if explicitly set with flag [8240] #3563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maiamcc
commented
Jul 7, 2020
| } | ||
|
|
||
| func TestContainerBuildLocal(t *testing.T) { |
There was a problem hiding this comment.
Deleted a bunch of tests that are covered more concisely in build_and_deployer_live_update_test.go
| f.assertContainerRestarts(1) | ||
| } | ||
|
|
||
| func TestReturnLastUnexpectedError(t *testing.T) { | ||
| f := newBDFixture(t, k8s.EnvGKE, container.RuntimeDocker) | ||
| f := newBDFixture(t, k8s.EnvDockerDesktop, container.RuntimeDocker) |
There was a problem hiding this comment.
We should probably fix the SanchoLiveUpdate manifest (i.e. the one we use by default in most of these tests) to NOT have a restart_container step in it, since that's been deprecated on the user side, and having that step in the manifest means we can't test it against UpdateModeKubectlExec (need to use a different update mode or a different test manifest). Tracked that work here but for now it's easier to just change the k8s cluster so we get an update mode that allows restart_container() -- we'll deal with the rest if/when we actually deprecate that codepath.
maiamcc
changed the title
This was referenced Jul 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello @landism, @nicks,
Please review the following commits I made in branch maiamcc/rm-default-synclet:
dee0445 (2020-07-07 18:16:45 -0400)
fix other tests, rm redundant ones
da404d3 (2020-07-07 17:14:54 -0400)
fix liveupdate tests that expected synclet
12a71c2 (2020-07-07 12:19:47 -0400)
only use synclet with explicit flag (needs tests)
Code review reminders, by giving a LGTM you attest that: