Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve node read permission error message, provide a way to disable #3280

Closed
jazzdan opened this issue May 5, 2020 · 1 comment · Fixed by #3281
Closed

Improve node read permission error message, provide a way to disable #3280

jazzdan opened this issue May 5, 2020 · 1 comment · Fixed by #3281
Labels
bug Something isn't working

Comments

@jazzdan
Copy link
Contributor

jazzdan commented May 5, 2020

If you don't have permissions to read nodes when you start Tilt you'll get this error message:

Starting Tilt (v0.12.2, built 2020-02-21)…
ERROR: Tilt could not read your node configuration
 Ask your Kubernetes admin for access to run `kubectl get nodes`.
 Detail: nodes is forbidden: User "myuser" cannot list resource "nodes" in API group "" at the cluster scope

We should do more to explain what this error means and in what situations it's safe to ignore.

Additionally we provide a way to disable this check if a user decides they don't care about the optimizations it would enable.
@jazzdan jazzdan added the bug Something isn't working label May 5, 2020
@jazzdan jazzdan changed the title Improve node read permission error message, provide a way to disabke Improve node read permission error message, provide a way to disable May 5, 2020
@nicks
Copy link
Member

nicks commented May 5, 2020

I'd be in favor of just removing this message or making it a Debug log. The synclet is the only thing that needs the container runtime (#3245), and as we de-emphasize it, this will be much less important

jazzdan pushed a commit that referenced this issue May 5, 2020
k8s: move forbidden runtime check to debug log
74e2f4a 
This error message is not as important as it was with the sunsetting of
the synclet. Better to move it to a debug log since there are plenty
of users for whom Tilt works fine without node read permissions.

Fixes #3280
@jazzdan jazzdan mentioned this issue May 5, 2020
Merged
jazzdan pushed a commit that referenced this issue May 5, 2020
k8s: move forbidden runtime check to debug log (#3281)
8a15f2c 
This error message is not as important as it was with the sunsetting of
the synclet. Better to move it to a debug log since there are plenty
of users for whom Tilt works fine without node read permissions.

Fixes #3280
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

k8s: move forbidden runtime check to debug log tilt-dev/tilt
2 participants
@nicks @jazzdan