Update queryParamsTransition to not change QueryParams if transition …

…has been aborted
tildeio · Jul 17, 2020 · a4bb230 · a4bb230
1 parent d8231d3
commit a4bb230
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/lib/router/router.ts b/lib/router/router.ts
@@ -137,10 +137,12 @@ export default abstract class Router<T extends Route> {
 
       newTransition.promise = newTransition.promise!.then(
         (result: TransitionState<T> | Route | Error | undefined) => {
-          this._updateURL(newTransition, oldState);
-          this.didTransition(this.currentRouteInfos!);
-          this.toInfos(newTransition, newState.routeInfos, true);
-          this.routeDidChange(newTransition);
+          if (!newTransition.isAborted) {
+            this._updateURL(newTransition, oldState);
+            this.didTransition(this.currentRouteInfos!);
+            this.toInfos(newTransition, newState.routeInfos, true);
+            this.routeDidChange(newTransition);
+          }
           return result;
         },
         null,