Update queryParamsTransition to not change QueryParams if transition …

…has been aborted
tildeio · Jul 17, 2020 · 8da70ea · 8da70ea
1 parent d8231d3
commit 8da70ea
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/lib/router/router.ts b/lib/router/router.ts
@@ -86,7 +86,7 @@ export default abstract class Router<T extends Route> {
     @param {Function} callback
   */
   map(callback: MatchCallback) {
-    this.recognizer.map(callback, function(recognizer, routes) {
+    this.recognizer.map(callback, function (recognizer, routes) {
       for (let i = routes.length - 1, proceed = true; i >= 0 && proceed; --i) {
         let route = routes[i];
         let handler = route.handler as string;
@@ -137,10 +137,12 @@ export default abstract class Router<T extends Route> {
 
       newTransition.promise = newTransition.promise!.then(
         (result: TransitionState<T> | Route | Error | undefined) => {
-          this._updateURL(newTransition, oldState);
-          this.didTransition(this.currentRouteInfos!);
-          this.toInfos(newTransition, newState.routeInfos, true);
-          this.routeDidChange(newTransition);
+          if (!newTransition.isAborted) {
+            this._updateURL(newTransition, oldState);
+            this.didTransition(this.currentRouteInfos!);
+            this.toInfos(newTransition, newState.routeInfos, true);
+            this.routeDidChange(newTransition);
+          }
           return result;
         },
         null,
@@ -821,7 +823,7 @@ export default abstract class Router<T extends Route> {
   */
   reset() {
     if (this.state) {
-      forEach<InternalRouteInfo<T>>(this.state.routeInfos.slice().reverse(), function(routeInfo) {
+      forEach<InternalRouteInfo<T>>(this.state.routeInfos.slice().reverse(), function (routeInfo) {
         let route = routeInfo.route;
         if (route !== undefined) {
           if (route.exit !== undefined) {