Updated #103: Build route specificity for the whole route #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Route specificity was being limited to only that of the last segment. This was incorrect causing some regressions in Ember. Original PR at: tildeio#103
|
I updated my PR with your test before seeing this. I'm happy just merging this as well. Thank you for being on top of this 👍 |
|
@wycats and/or @krisselden - Can one of y'all review this? |
|
Closing in favor of the updated #103 which is the same code - @wycats @krisselden please review there, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Route specificity was being limited to only that of the last segment. This was incorrect causing some regressions in Ember.
Original PR at: #103