Skip to content

Commit

Permalink
Merge pull request #75 from asakusuma/upgrade-docs
Browse files Browse the repository at this point in the history
Add docs and script to check typescript upgrades
  • Loading branch information
rwjblue authored Nov 19, 2018
2 parents ae24b59 + c7a69a8 commit 9fe82a0
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 0 deletions.
10 changes: 10 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -82,3 +82,13 @@ This selects only ts files from the input to compile and merges emitted files wi
const { filterTypescript } = require("broccoli-typescript-compiler");
let output = filterTypescript(input, options);
```

### Developemnt

## How to upgrade `typescript`

1. Update `typescript` in `package.json`
2. Run `yarn run generate-tsconfig-interface`
3. Update `vendor/typescript`. `cd vendor/typescript && git fetch --tags && git checkout v[new-version-of-typescript]`
4. Commit all of the above changes
5. Run `yarn test`. There may be some changes needed to the tests to accomidate changes in TypeScript.
8 changes: 8 additions & 0 deletions tests/submodule-version-test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
QUnit.module("submodule typescript version", () => {
QUnit.test("matches installed typescript version", assert => {
const installedVersion = require('typescript/package').version;
const testFixturesVersion = require('../../vendor/typescript/package').version;
assert.equal(installedVersion, testFixturesVersion, `Installed Typescript version (${installedVersion}) does not match
the test fixture version in 'vendor/typescript' (${testFixturesVersion})`);
});
});

0 comments on commit 9fe82a0

Please sign in to comment.