Add metadata deletion capability to FileSystem trait
#229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
Connor1996
reviewed
Jun 22, 2022
Signed-off-by: tabokie <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #229 +/- ##
==========================================
- Coverage 97.18% 97.12% -0.07%
==========================================
Files 29 30 +1
Lines 9066 9216 +150
==========================================
+ Hits 8811 8951 +140
- Misses 255 265 +10
Continue to review full report at Codecov.
|
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
…ete-file Signed-off-by: tabokie <[email protected]>
tabokie
changed the title
delete to FileSystem trait APIFileSystem trait
Signed-off-by: tabokie <[email protected]>
tabokie
added a commit
to tabokie/raft-engine
that referenced
this pull request
Jun 23, 2022
* let file system manage file deletion Signed-off-by: tabokie <[email protected]> * update changelog Signed-off-by: tabokie <[email protected]> * address comment and fix test Signed-off-by: tabokie <[email protected]> * detect and cleanup stale metadata on startup Signed-off-by: tabokie <[email protected]> * update changelog Signed-off-by: tabokie <[email protected]> * fix issues Signed-off-by: tabokie <[email protected]>
tabokie
added a commit
that referenced
this pull request
Jun 23, 2022
* let file system manage file deletion Signed-off-by: tabokie <[email protected]> * update changelog Signed-off-by: tabokie <[email protected]> * address comment and fix test Signed-off-by: tabokie <[email protected]> * detect and cleanup stale metadata on startup Signed-off-by: tabokie <[email protected]> * update changelog Signed-off-by: tabokie <[email protected]> * fix issues Signed-off-by: tabokie <[email protected]>
LykxSassinator
added a commit
to LykxSassinator/raft-engine
that referenced
this pull request
Jun 23, 2022
Signed-off-by: Lucasliang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User should be allowed to manage file deletion. For example, in TiKV, file encryption key can be deleted once the corresponding file is deleted.