tolerate fallocate failure and print IO error in debug form #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tabokie <[email protected]>
Signed-off-by: tabokie <[email protected]>
Connor1996
reviewed
Jun 21, 2022
src/env/default.rs
Outdated
| @@ -152,18 +152,14 @@ impl LogFd { | |||
| }); | |||
| #[cfg(target_os = "linux")] | |||
| { | |||
| fcntl::fallocate( | |||
| let _ = fcntl::fallocate( | |||
There was a problem hiding this comment.
Not supported on some platforms. And we call it only for performance reason, skipping it is okay (e.g. already skipped on macos).
Signed-off-by: tabokie <[email protected]>
tabokie
changed the title
Signed-off-by: tabokie <[email protected]>
tabokie
changed the title
Signed-off-by: tabokie <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #225 +/- ##
==========================================
- Coverage 97.16% 97.12% -0.05%
==========================================
Files 29 29
Lines 9007 9030 +23
==========================================
+ Hits 8752 8770 +18
- Misses 255 260 +5
Continue to review full report at Codecov.
|
Signed-off-by: tabokie <[email protected]>
tabokie
added a commit
to tabokie/raft-engine
that referenced
this pull request
Jun 21, 2022
* tolerate fallocate failure and print IO error in debug form Signed-off-by: tabokie <[email protected]> * update CHANGELOG.md Signed-off-by: tabokie <[email protected]> * only tolerate e=95 Signed-off-by: tabokie <[email protected]> * still tolerate unconditionally Signed-off-by: tabokie <[email protected]> * update doc Signed-off-by: tabokie <[email protected]> * add a failpoint test Signed-off-by: tabokie <[email protected]>
tabokie
added a commit
that referenced
this pull request
Jun 22, 2022
) * tolerate fallocate failure and print IO error in debug form Signed-off-by: tabokie <[email protected]> * update CHANGELOG.md Signed-off-by: tabokie <[email protected]> * only tolerate e=95 Signed-off-by: tabokie <[email protected]> * still tolerate unconditionally Signed-off-by: tabokie <[email protected]> * update doc Signed-off-by: tabokie <[email protected]> * add a failpoint test Signed-off-by: tabokie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fallocateis more performant but not supported on some platforms. This patch ignores its error.Also fix the issue that
std::io::Errordoesn't print well for custom error kind.Signed-off-by: tabokie [email protected]