Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace app builder with derive macros in stress tool #163

Merged
merged 8 commits into from
Dec 4, 2021

Conversation

ztelur
Copy link
Contributor

@ztelur ztelur commented Dec 1, 2021

replace structopt with clap-v3.0.0-beta.5 in ctl and stress tool referred to #155

Close #155.

@ztelur
Copy link
Contributor Author

ztelur commented Dec 1, 2021

/cc @tabokie

Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove Cargo.lock from you changeset? After that you can also add "Cargo.lock" to gitignore.

stress/src/main.rs Outdated Show resolved Hide resolved
stress/src/main.rs Outdated Show resolved Hide resolved
ctl/Cargo.toml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 1, 2021

Codecov Report

Merging #163 (4742f37) into master (90a50b7) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #163      +/-   ##
==========================================
+ Coverage   96.96%   96.98%   +0.01%     
==========================================
  Files          26       26              
  Lines        6597     6597              
==========================================
+ Hits         6397     6398       +1     
+ Misses        200      199       -1     
Impacted Files Coverage Δ
src/codec.rs 98.67% <0.00%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90a50b7...4742f37. Read the comment docs.

@ztelur
Copy link
Contributor Author

ztelur commented Dec 3, 2021

Could you remove Cargo.lock from you changeset? After that you can also add "Cargo.lock" to gitignore.

Done

@ztelur
Copy link
Contributor Author

ztelur commented Dec 3, 2021

BTW, running stress with default parameter value will lead to error "Write region count must be smaller than region-count / write-threads". Should we change the default value of those three parameters
target/debug/stress --path tmp

@tabokie
Copy link
Member

tabokie commented Dec 3, 2021

BTW, running stress with default parameter value will lead to error "Write region count must be smaller than region-count / write-threads". Should we change the default value of those three parameters target/debug/stress --path tmp

@ztelur Please do.

Copy link
Member

@tabokie tabokie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks good.

stress/src/main.rs Outdated Show resolved Hide resolved
Signed-off-by: randy <[email protected]>
@tabokie tabokie merged commit e87faf7 into tikv:master Dec 4, 2021
tabokie added a commit that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace app builder with derive macros in stress tool
2 participants