-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace app builder with derive macros in stress tool #163
Conversation
Signed-off-by: Randy <[email protected]>
Signed-off-by: Randy <[email protected]>
Signed-off-by: Randy <[email protected]>
Signed-off-by: Randy <[email protected]>
Signed-off-by: Randy <[email protected]>
/cc @tabokie |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you remove Cargo.lock
from you changeset? After that you can also add "Cargo.lock" to gitignore.
Codecov Report
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
+ Coverage 96.96% 96.98% +0.01%
==========================================
Files 26 26
Lines 6597 6597
==========================================
+ Hits 6397 6398 +1
+ Misses 200 199 -1
Continue to review full report at Codecov.
|
Signed-off-by: Randy <[email protected]>
Signed-off-by: Randy <[email protected]>
Done |
BTW, running stress with default parameter value will lead to error "Write region count must be smaller than region-count / write-threads". Should we change the default value of those three parameters |
@ztelur Please do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest looks good.
Signed-off-by: randy <[email protected]>
Introduced in #163. Signed-off-by: tabokie <[email protected]>
replace structopt with clap-v3.0.0-beta.5 in ctl and stress tool referred to #155
Close #155.