-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimize mutually exclusive features #130
Conversation
Signed-off-by: mornyx <[email protected]>
Please also modify the CHANGELOG.md . It's a change and we'll release a 0.10.0 version for it 😢 |
Maybe we can add a section named |
The |
Oh, that's it! How about I add it to [Unreleased] first? Maybe this change wasn't enough to release a version on its own. |
Signed-off-by: mornyx <[email protected]>
Signed-off-by: mornyx <[email protected]>
Should this be |
Yes. It's expected. I'll rename the
IMO, |
/assign @YangKeao Ping~ Please see if there is any room for improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
In general, using mutually exclusive features will cause some trouble in downstream. Some reasons can be found here: https://doc.rust-lang.org/cargo/reference/features.html#mutually-exclusive-features
Signed-off-by: mornyx [email protected]