Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix TestScatterRegions #9108

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Feb 27, 2025

What problem does this PR solve?

Issue Number: Close #7109.

What is changed and how does it work?

also fix

[2025/02/26 09:39:09.226 +00:00] [INFO] [cluster.go:1751] ["auto gc the tombstone store success"] [store="id:1 address:\"localhost:1\" state:Tombstone physically_destroyed:true node_state:Removed "] [down-time=483489h39m9.226474515s]

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 27, 2025
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx changed the title tests: fix TestScatterRegions tests: fix TestScatterRegions Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.31%. Comparing base (ecb9a61) to head (781831b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9108      +/-   ##
==========================================
+ Coverage   76.28%   76.31%   +0.03%     
==========================================
  Files         473      473              
  Lines       71663    71663              
==========================================
+ Hits        54665    54689      +24     
+ Misses      13566    13552      -14     
+ Partials     3432     3422      -10     
Flag Coverage Δ
unittests 76.31% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@rleungx rleungx requested review from JmPotato and lhy1024 February 28, 2025 02:28
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 28, 2025
@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 3, 2025
Copy link
Contributor

ti-chi-bot bot commented Mar 3, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-28 05:54:16.529936081 +0000 UTC m=+594404.483094342: ☑️ agreed by lhy1024.
  • 2025-03-03 04:02:41.014317166 +0000 UTC m=+241474.143236906: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit 8857c2e into tikv:master Mar 3, 2025
25 checks passed
@rleungx rleungx deleted the fix-test-2025-2 branch March 3, 2025 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestScatterRegions is unstable
3 participants