Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: refactor TSO server forwarding function #9096

Merged
merged 4 commits into from
Feb 26, 2025

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #4399.

What is changed and how does it work?

Refactor TSO server forwarding function to eliminate the passing of parameters flying everywhere.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/tso Timestamp Oracle. label Feb 24, 2025
@JmPotato JmPotato requested review from okJiang and rleungx February 24, 2025 08:02
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Feb 24, 2025
@JmPotato JmPotato requested a review from lhy1024 February 24, 2025 08:02
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 24, 2025
@JmPotato JmPotato force-pushed the refine_tso_forward branch 4 times, most recently from 5b6c547 to a1ab84b Compare February 24, 2025 08:18
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.34%. Comparing base (6504311) to head (b8c1b4b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9096      +/-   ##
==========================================
- Coverage   76.34%   76.34%   -0.01%     
==========================================
  Files         468      468              
  Lines       71729    71727       -2     
==========================================
- Hits        54765    54759       -6     
+ Misses      13550    13545       -5     
- Partials     3414     3423       +9     
Flag Coverage Δ
unittests 76.34% <91.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 24, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 25, 2025
Copy link
Contributor

ti-chi-bot bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Feb 25, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-24 09:10:06.082913627 +0000 UTC m=+260554.036071886: ☑️ agreed by rleungx.
  • 2025-02-25 09:02:52.572776403 +0000 UTC m=+346520.525934664: ☑️ agreed by okJiang.

@ti-chi-bot ti-chi-bot bot merged commit 21a4c7e into tikv:master Feb 26, 2025
25 checks passed
@JmPotato JmPotato deleted the refine_tso_forward branch February 26, 2025 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/tso Timestamp Oracle. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants