Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource group: support more mode for burstable #9044

Merged
merged 13 commits into from
Feb 26, 2025
Merged

resource group: support more mode for burstable #9044

merged 13 commits into from
Feb 26, 2025

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Feb 7, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: Close #9057

What is changed and how does it work?

Check List

Tests

  • Unit test
    image

Release note

None.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates the PR's author has signed the dco. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 7, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.52941% with 9 lines in your changes missing coverage. Please review.

Project coverage is 76.35%. Comparing base (0c13897) to head (ed92c26).
Report is 1 commits behind head on master.

❌ Your patch status has failed because the patch coverage (73.52%) is below the target coverage (74.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #9044      +/-   ##
==========================================
+ Coverage   76.32%   76.35%   +0.02%     
==========================================
  Files         468      468              
  Lines       71727    71746      +19     
==========================================
+ Hits        54749    54781      +32     
+ Misses      13558    13548      -10     
+ Partials     3420     3417       -3
Flag Coverage Δ
unittests 76.35% <73.52%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@lhy1024
add test
a5b7272 
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 7, 2025
@lhy1024
fix lint
56cbe1f 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
add more test
7810499 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
add more test
7b46aef 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
fix again
928c773 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
fix
cd74c89 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
remove BurstLimitFactor
7674702 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 marked this pull request as ready for review February 11, 2025 05:56
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 11, 2025
@lhy1024 lhy1024 requested review from nolouch and JmPotato February 13, 2025 05:44
@lhy1024
address comments
b91a317 
Signed-off-by: lhy1024 <[email protected]>
nolouch
nolouch reviewed Feb 17, 2025
View reviewed changes
pkg/mcs/resourcemanager/server/token_buckets.go Outdated
@@ -191,6 +222,15 @@ func (gts *GroupTokenBucketState) balanceSlotTokens(
}
return
}
if getBurstableMode(settings) == unlimited || settings.FillRate == unlimitedRate {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why should we change the unlimited behavior from before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of this is to be consistent with the previous behavior, before this pr, when fillRate was set to unlimited, it would be set to burstable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/pingcap/tidb/blob/8059751eafd7461a66e17c877f5e9323dd296e84/pkg/ddl/resource_group.go#L259

Copy link
Contributor

@nolouch nolouch Feb 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's tidb behavior, I think we don't need to change it on the PD side to avoid some users directly using API.

@lhy1024
address comments
b510de3 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024
address comments
83a976c 
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Feb 19, 2025
JmPotato
JmPotato reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@JmPotato JmPotato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

@lhy1024
address comments
4c2be1d 
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Feb 26, 2025
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JmPotato, nolouch

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Feb 26, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-02-19 04:00:29.628622139 +0000 UTC m=+1020272.024844195: ☑️ agreed by nolouch.
  • 2025-02-26 08:52:26.297972318 +0000 UTC m=+432294.251130583: ☑️ agreed by JmPotato.

@ti-chi-bot ti-chi-bot bot merged commit a695261 into tikv:master Feb 26, 2025
24 of 25 checks passed
@lhy1024 lhy1024 deleted the burst-limit3 branch February 26, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JmPotato JmPotato JmPotato approved these changes

@nolouch nolouch nolouch approved these changes

Assignees
No one assigned
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allocating resources under RU_PER_SEC in priority
3 participants
@lhy1024 @JmPotato @nolouch