Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: make history-sample-interval and history-sample-duration configurable (#7878) #7893

Closed

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7878

What problem does this PR solve?

Issue Number: Close #7877

What is changed and how does it work?

Check List

Tests

  • Unit test

  • Integration test

  • Manual test (add detailed scripts or steps below)

  • Has the configuration change

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Mar 7, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HuSharp
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR. labels Mar 7, 2024
@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx March 7, 2024 06:34
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 7, 2024
Signed-off-by: lhy1024 <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 7, 2024
@lhy1024
Copy link
Contributor

lhy1024 commented Mar 7, 2024

/retest

@lhy1024
Copy link
Contributor

lhy1024 commented Mar 7, 2024

/test build

Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Merging #7893 (16b6345) into release-7.5 (8783927) will increase coverage by 0.06%.
Report is 3 commits behind head on release-7.5.
The diff coverage is 88.60%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.5    #7893      +/-   ##
===============================================
+ Coverage        74.51%   74.57%   +0.06%     
===============================================
  Files              444      444              
  Lines            48156    48247      +91     
===============================================
+ Hits             35883    35982      +99     
+ Misses            9079     9074       -5     
+ Partials          3194     3191       -3     
Flag Coverage Δ
unittests 74.57% <88.60%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 20, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Mar 27, 2024
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 3, 2024
@nolouch
Copy link
Contributor

nolouch commented Apr 3, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 68a2151

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 3, 2024

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor

lhy1024 commented Apr 3, 2024

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 3, 2024
@lhy1024
Copy link
Contributor

lhy1024 commented Apr 3, 2024

Do we need to merge it to release 7.5? It's provided to special user.

@nolouch
Copy link
Contributor

nolouch commented Apr 7, 2024

IMO, no need.

@lhy1024 lhy1024 closed this Apr 7, 2024
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label May 20, 2024
Copy link
Contributor

ti-chi-bot bot commented May 20, 2024

This cherry pick PR is for a release branch and has not yet been approved by triage owners.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick:

  1. It must be approved by the approvers firstly.
  2. AFTER it has been approved by approvers, please wait for the cherry-pick merging approval from triage owners.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-7.5 This PR is cherry-picked to release-7.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants