Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: add http server for heartbeat bench #7685

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jan 9, 2024

What problem does this PR solve?

Issue Number: Ref #7703.

What is changed and how does it work?

Check List

Tests

  • Manual test
# ryan @ 10 in ~ [11:57:52] C:130
$ curl -X GET http://127.0.0.1:38767/config
{
    "PDAddr": "127.0.0.1:2379",
    "StatusAddr": "127.0.0.1:38767",
    "log": {
        "level": "",
        "format": "text",
        "disable-timestamp": false,
        "file": {
            "filename": "",
            "max-size": 0,
            "max-days": 0,
            "max-backups": 0
        },
        "development": false,
        "disable-caller": false,
        "disable-stacktrace": false,
        "disable-error-verbose": false,
        "sampling": null,
        "error-output-path": ""
    },
    "Logger": {},
    "LogProps": {
        "Core": {
            "LevelEnabler": "info"
        },
        "Syncer": {},
        "Level": "info"
    },
    "store-count": 50,
    "region-count": 1000000,
    "key-length": 56,
    "replica": 3,
    "leader-update-ratio": 0.06,
    "epoch-update-ratio": 0.04,
    "space-update-ratio": 0.15,
    "flow-update-ratio": 0.35,
    "sample": false,
    "round": 0
}%

# ryan @ 10 in ~ [11:58:07] C:130
$ curl -X PUT http://127.0.0.1:38767/config -H 'Content-Type: application/json' --data '{"flow-update-ratio": 0.0}'
Successfully updated the configuration%

# ryan @ 10 in ~ [11:58:14]
$ curl -X GET http://127.0.0.1:38767/config
{
    "PDAddr": "127.0.0.1:2379",
    "StatusAddr": "127.0.0.1:38767",
    "log": {
        "level": "",
        "format": "text",
        "disable-timestamp": false,
        "file": {
            "filename": "",
            "max-size": 0,
            "max-days": 0,
            "max-backups": 0
        },
        "development": false,
        "disable-caller": false,
        "disable-stacktrace": false,
        "disable-error-verbose": false,
        "sampling": null,
        "error-output-path": ""
    },
    "Logger": {},
    "LogProps": {
        "Core": {
            "LevelEnabler": "info"
        },
        "Syncer": {},
        "Level": "info"
    },
    "store-count": 50,
    "region-count": 1000000,
    "key-length": 56,
    "replica": 3,
    "leader-update-ratio": 0.06,
    "epoch-update-ratio": 0.04,
    "space-update-ratio": 0.15,
    "flow-update-ratio": 0,
    "sample": false,
    "round": 0
}%

Release note

None.

Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Jan 9, 2024
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and lhy1024 January 9, 2024 09:50
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #7685 (eb660b8) into master (421959f) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head eb660b8 differs from pull request most recent head 96c7f8c. Consider uploading reports for the commit 96c7f8c to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7685      +/-   ##
==========================================
+ Coverage   73.56%   73.59%   +0.02%     
==========================================
  Files         429      429              
  Lines       47435    47435              
==========================================
+ Hits        34896    34910      +14     
+ Misses       9561     9541      -20     
- Partials     2978     2984       +6     
Flag Coverage Δ
unittests 73.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

fs.StringVar(&cfg.PDAddr, "pd", "http://127.0.0.1:2379", "pd address")
fs.StringVar(&cfg.StatusAddr, "status-addr", "http://127.0.0.1:20180", "status address")
fs.StringVar(&cfg.PDAddr, "pd", "http://10.2.8.101:2379", "pd address")
fs.StringVar(&cfg.StatusAddr, "status-addr", "http://10.2.8.101:30180", "status address")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to add HTTP scheme prefix

Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx marked this pull request as ready for review January 11, 2024 04:05
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 11, 2024
@CabinfeverB CabinfeverB added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 11, 2024
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 11, 2024
@rleungx
Copy link
Member Author

rleungx commented Jan 11, 2024

/merge

Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

This pull request has been accepted and is ready to merge.

Commit hash: eb660b8

@ti-chi-bot ti-chi-bot bot added status/can-merge Indicates a PR has been approved by a committer. and removed do-not-merge/needs-linked-issue labels Jan 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

@rleungx: Your PR was out of date, I have automatically updated it for you.

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 1203511 into tikv:master Jan 11, 2024
19 checks passed
@rleungx rleungx deleted the add-http-server branch January 11, 2024 06:04
pingandb pushed a commit to pingandb/pd that referenced this pull request Jan 18, 2024
ref tikv#4399

Signed-off-by: Ryan Leung <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Signed-off-by: pingandb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants