Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: upgrade gin version from v1.8.1 to v1.9.1 (#7451) #7459

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #7451

What problem does this PR solve?

Issue Number: Close #7438

What is changed and how does it work?

Upgrade Gin version to v1.9.1 to solve some security issues

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

Upgrade Gin version to v1.9.1 to solve some security issues.

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Nov 28, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • CabinfeverB
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot requested review from JmPotato and rleungx November 28, 2023 02:23
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 28, 2023
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbce3fb) 75.61% compared to head (25668f9) 75.54%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-6.5    #7459      +/-   ##
===============================================
- Coverage        75.61%   75.54%   -0.07%     
===============================================
  Files              332      332              
  Lines            33745    33745              
===============================================
- Hits             25515    25494      -21     
- Misses            6040     6052      +12     
- Partials          2190     2199       +9     
Flag Coverage Δ
unittests 75.54% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rleungx rleungx force-pushed the cherry-pick-7451-to-release-6.5 branch from eca08f5 to 07d9d55 Compare November 28, 2023 02:59
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx force-pushed the cherry-pick-7451-to-release-6.5 branch from 07d9d55 to 25668f9 Compare November 28, 2023 03:00
@ti-chi-bot ti-chi-bot bot added status/LGT1 Indicates that a PR has LGTM 1. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 28, 2023
@rleungx
Copy link
Member

rleungx commented Nov 28, 2023

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 28, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 25668f9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit ba7f2fe into tikv:release-6.5 Nov 28, 2023
@HuSharp HuSharp deleted the cherry-pick-7451-to-release-6.5 branch November 28, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. ok-to-test Indicates a PR is ready to be tested. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants