Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: add get first region meta support by using empty search key. #72

Merged
merged 1 commit into from
Apr 8, 2016

Conversation

qiuyesuifeng
Copy link
Contributor

firstRegionStartKey = t.startKey
firstRegionEndKey = t.splitKey
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think firstRegionStartKey, firstRegionEndKey := tbl[0].startKey, tbl[0].splitKey would be more straight forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better, actually i have done as what u want.

@qiuyesuifeng qiuyesuifeng force-pushed the qiuyesuifeng/first-region branch from daa7ddf to ecdb25a Compare April 8, 2016 04:06
@siddontang
Copy link
Contributor

LGTM

@qiuyesuifeng
Copy link
Contributor Author

@disksing PTAL

@disksing
Copy link
Contributor

disksing commented Apr 8, 2016

LGTM

@qiuyesuifeng qiuyesuifeng merged commit a19e5a5 into master Apr 8, 2016
@qiuyesuifeng qiuyesuifeng deleted the qiuyesuifeng/first-region branch April 8, 2016 13:26
rleungx added a commit to rleungx/pd that referenced this pull request Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants