Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load all gc sp v2 #6750

Merged
merged 11 commits into from
Jul 6, 2023
Merged

load all gc sp v2 #6750

merged 11 commits into from
Jul 6, 2023

Conversation

ystaticy
Copy link
Contributor

@ystaticy ystaticy commented Jul 5, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #6752

What is changed and how does it work?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release note

None.

@ystaticy
load all gc sp v2
6ca2aec 
Signed-off-by: ystaticy <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • disksing
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Jul 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

Hi @ystaticy. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from disksing and rleungx July 5, 2023 05:13
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue labels Jul 5, 2023
@ystaticy
load all gc sp v2
afecaec 
Signed-off-by: ystaticy <[email protected]>
@ystaticy ystaticy marked this pull request as ready for review July 5, 2023 05:53
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 5, 2023
@ystaticy
update kvproto
bec2676 
Signed-off-by: ystaticy <[email protected]>
@codecov
Copy link

codecov bot commented Jul 5, 2023 •
edited
Loading

Codecov Report

Merging #6750 (0dbae17) into master (b9adc83) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6750      +/-   ##
==========================================
- Coverage   74.33%   74.31%   -0.03%     
==========================================
  Files         411      411              
  Lines       43083    43126      +43     
==========================================
+ Hits        32027    32048      +21     
- Misses       8192     8224      +32     
+ Partials     2864     2854      -10
Flag Coverage Δ
unittests 74.31% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 5, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rleungx
rleungx reviewed Jul 6, 2023
View reviewed changes
server/gc_service.go Outdated Show resolved Hide resolved
rleungx
rleungx approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 6, 2023
ystaticy added 2 commits July 6, 2023 11:16
@ystaticy
fix comments
cfe1149 
Signed-off-by: ystaticy <[email protected]>
@ystaticy
resolve conflicts
708ecd9 
Signed-off-by: ystaticy <[email protected]>
@ystaticy
fix comments
0dbae17 
Signed-off-by: ystaticy <[email protected]>
@ti-chi-bot ti-chi-bot bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 6, 2023
@disksing
Copy link
Contributor

disksing commented Jul 6, 2023

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 0dbae17

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 6, 2023
@CabinfeverB
Copy link
Member

It seems needs-rebase not deleted by bot

@CabinfeverB CabinfeverB removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 6, 2023
@disksing
Copy link
Contributor

disksing commented Jul 6, 2023

/build

@disksing
Copy link
Contributor

disksing commented Jul 6, 2023

/test

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@disksing: The /test command needs one or more targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test integration-copr-test

Use /test all to run the following jobs that were automatically triggered:

  • tikv/pd/ghpr_build

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@disksing
Copy link
Contributor

disksing commented Jul 6, 2023

/test build

@disksing
Copy link
Contributor

disksing commented Jul 6, 2023

/retest

@CabinfeverB
Copy link
Member

/test build

@ti-chi-bot ti-chi-bot bot merged commit fbedf3a into tikv:master Jul 6, 2023
@ystaticy ystaticy mentioned this pull request Dec 6, 2023
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@rleungx rleungx rleungx approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ystaticy @disksing @CabinfeverB @rleungx