Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: remove redundant code #6716

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented Jun 29, 2023

What problem does this PR solve?

Issue Number: ref #4399

What is changed and how does it work?

Check List

Release note

None.

Signed-off-by: husharp <[email protected]>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 29, 2023
@ti-chi-bot ti-chi-bot bot requested review from disksing and JmPotato June 29, 2023 08:52
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 29, 2023
@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.09 ⚠️

Comparison is base (3b59a78) 74.53% compared to head (90c2eaa) 74.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6716      +/-   ##
==========================================
- Coverage   74.53%   74.44%   -0.09%     
==========================================
  Files         416      416              
  Lines       43596    43595       -1     
==========================================
- Hits        32493    32456      -37     
- Misses       8203     8235      +32     
- Partials     2900     2904       +4     
Flag Coverage Δ
unittests 74.44% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/api/router.go 97.97% <ø> (-0.01%) ⬇️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 29, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 29, 2023
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 29, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 90c2eaa

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 29, 2023
@ti-chi-bot ti-chi-bot bot merged commit fa721e7 into tikv:master Jun 29, 2023
@HuSharp HuSharp deleted the remove_redundant_code branch June 29, 2023 13:03
@HuSharp HuSharp restored the remove_redundant_code branch August 24, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants