Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

schedule: fix location label in placement rule not work well with rule checker (#6633) #6643

Closed

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #6633

What problem does this PR solve?

Issue Number: Close #6637

What is changed and how does it work?

This PR is going to use the region store as the source instead of rule stores.

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.2 labels Jun 20, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx June 20, 2023 08:39
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 63.63% and project coverage change: +0.12 🎉

Comparison is base (0934e64) 74.52% compared to head (1be27b2) 74.64%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-7.2    #6643      +/-   ##
===============================================
+ Coverage        74.52%   74.64%   +0.12%     
===============================================
  Files              417      417              
  Lines            43056    43063       +7     
===============================================
+ Hits             32086    32144      +58     
+ Misses            8113     8072      -41     
+ Partials          2857     2847      -10     
Flag Coverage Δ
unittests 74.64% <63.63%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/schedule/checker/replica_strategy.go 79.62% <0.00%> (-6.38%) ⬇️
pkg/schedule/checker/rule_checker.go 84.34% <100.00%> (+0.88%) ⬆️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rleungx rleungx closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants