Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcs: update client when meet transport is closing #6341

Merged
merged 4 commits into from
Apr 23, 2023
Merged

mcs: update client when meet transport is closing #6341

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10a15da
mcs: update client when meet transport is closing
lhy1024 Apr 19, 2023
c8820e5
address comments
lhy1024 Apr 19, 2023
aa4caf2
add retry
lhy1024 Apr 19, 2023
d6c0b72
Merge branch 'master' into update-client
ti-chi-bot[bot] Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion server/grpc_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"io"
"path"
"strconv"
"strings"
"sync/atomic"
"time"

Expand Down Expand Up @@ -1787,7 +1788,12 @@ func (s *GrpcServer) getGlobalTSOFromTSOServer(ctx context.Context) (pdpb.Timest
})
ts, err := forwardStream.Recv()
if err != nil {
log.Error("get global tso from tso server failed", zap.Error(err))
log.Error("get global tso from tso service primary addr failed", zap.Error(err), zap.String("tso", forwardedHost))
if strings.Contains(err.Error(), "transport is closing") {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if it is another kind of error?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the client for any errors encountered? I'm not sure if this will keep updating repeatedly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add more descriptions about why this issue happens?

Copy link
Contributor Author

@lhy1024 lhy1024 Apr 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the previous test, after a tso election, tikv/tidb still got tso normally, but update gc point failed and this error was returned, which means that the grpc stream was automatically updated successfully, but the client is still using the previous grpc stream. It means we should update the client when we encounter this error. Also I'm not sure if it returns other errors as well, in this scenario.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then, how to ensure that this situation does not happen again? Maybe we need to first know how many kinds of errors it might return.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it is better to judge by error code https://github.com/grpc/grpc-go/blob/16651f60ddc5b1adb810fca8b1a732d57fecb270/codes/codes.go#L180

"transport is closing" is defined in https://github.com/grpc/grpc-go/blob/3151e834fa2536844f801bb132c684fbb10364fd/internal/transport/transport.go#L782

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I will add retry with new client for this error

s.tsoClientPool.Lock()
delete(s.tsoClientPool.clients, forwardedHost)
s.tsoClientPool.Unlock()
}
return pdpb.Timestamp{}, err
}
return *ts.GetTimestamp(), nil
Expand Down