Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove periods and align case at the beginning of sentences #6034

Merged
merged 3 commits into from
Feb 22, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Feb 21, 2023

What problem does this PR solve?

Issue Number: Ref #4399

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024 lhy1024 requested review from nolouch and rleungx February 21, 2023 11:22
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 21, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 21, 2023
Signed-off-by: lhy1024 <[email protected]>
@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 74.86% // Head: 74.84% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (6fc48f9) compared to base (71f776f).
Patch coverage: 63.33% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6034      +/-   ##
==========================================
- Coverage   74.86%   74.84%   -0.02%     
==========================================
  Files         365      365              
  Lines       36552    36552              
==========================================
- Hits        27363    27358       -5     
  Misses       6798     6798              
- Partials     2391     2396       +5     
Flag Coverage Δ
unittests 74.84% <63.33%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/mcs/resource_manager/server/server.go 48.05% <0.00%> (ø)
tools/pd-analysis/analysis/parse_log.go 34.21% <0.00%> (ø)
pkg/dashboard/distroutil/distro.go 54.54% <33.33%> (ø)
server/cluster/unsafe_recovery_controller.go 78.70% <33.33%> (-0.35%) ⬇️
pkg/encryption/key_manager.go 70.11% <50.00%> (-1.60%) ⬇️
pkg/dashboard/adapter/manager.go 79.31% <75.00%> (ø)
tools/pd-analysis/analysis/transfer_counter.go 92.23% <75.00%> (ø)
pkg/audit/audit.go 91.66% <100.00%> (ø)
pkg/dashboard/keyvisual/input/core.go 33.33% <100.00%> (ø)
server/region_syncer/client.go 85.82% <100.00%> (-0.75%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 requested a review from rleungx February 22, 2023 03:23
@lhy1024 lhy1024 added the component/misc Some other things. label Feb 22, 2023
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 22, 2023
@rleungx rleungx added the require-LGT1 Indicates that the PR requires an LGTM. label Feb 22, 2023
@rleungx
Copy link
Member

rleungx commented Feb 22, 2023

/merge

@ti-chi-bot
Copy link
Member

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 6fc48f9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 22, 2023
@ti-chi-bot ti-chi-bot merged commit 723fd74 into tikv:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/misc Some other things. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants