-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resource_group_client: add defined errors #6033
Conversation
Signed-off-by: Cabinfever_B <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
client/errs/errno.go
Outdated
ErrClientGetResourceGroup = errors.Normalize("get resource group %s failed, %v", errors.RFCCodeText("PD:client:ErrClientGetResourceGroup")) | ||
ErrClientListResourceGroup = errors.Normalize("get all resource group failed, %v", errors.RFCCodeText("PD:client:ErrClientListResourceGroup")) | ||
ErrClientResourceGroupConfigUnavailable = errors.Normalize("resource group %s config is unavailable, %v", errors.RFCCodeText("PD:client:ErrClientResourceGroupConfigUnavailable")) | ||
ErrClientResourceGroupLimited = errors.Normalize("resource group limiter has no enough token", errors.RFCCodeText("PD:client:ErrClientResourceGroupLimited")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better use throttled
.
Signed-off-by: Cabinfever_B <[email protected]>
Codecov ReportBase: 74.81% // Head: 74.78% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #6033 +/- ##
==========================================
- Coverage 74.81% 74.78% -0.04%
==========================================
Files 365 365
Lines 36552 36552
==========================================
- Hits 27348 27335 -13
- Misses 6808 6819 +11
- Partials 2396 2398 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
client/errs/errno.go
Outdated
ErrClientGetResourceGroup = errors.Normalize("get resource group failed, %v", errors.RFCCodeText("PD:client:ErrClientGetResourceGroup")) | ||
ErrClientListResourceGroup = errors.Normalize("get all resource group failed, %v", errors.RFCCodeText("PD:client:ErrClientListResourceGroup")) | ||
ErrClientResourceGroupConfigUnavailable = errors.Normalize("resource group config is unavailable, %v", errors.RFCCodeText("PD:client:ErrClientResourceGroupConfigUnavailable")) | ||
ErrClientResourceGroupThrottled = errors.Normalize("exceed resource group quota limitation", errors.RFCCodeText("PD:client:ErrClientResourceGroupThrottled")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ErrClientResourceGroupThrottled = errors.Normalize("exceed resource group quota limitation", errors.RFCCodeText("PD:client:ErrClientResourceGroupThrottled")) | |
ErrClientResourceGroupThrottled = errors.Normalize("exceeded resource group quota limitation", errors.RFCCodeText("PD:client:ErrClientResourceGroupThrottled")) |
Signed-off-by: Cabinfever_B <[email protected]>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 9fc2228
|
@CabinfeverB: Your PR was out of date, I have automatically updated it for you. If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ref tikv#5851 Signed-off-by: Cabinfever_B <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
What problem does this PR solve?
Issue Number: ref #5851
What is changed and how does it work?
add defined error for other pkgs to judge
Check List
Tests
Release note