-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
basic implement tso gPRC service #5949
Conversation
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @binshi-bing. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7a38347
to
dd860c4
Compare
84bb7b3
to
e74aa09
Compare
e74aa09
to
a0f7ba8
Compare
5322919
to
c1ffc53
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5949 +/- ##
==========================================
+ Coverage 75.13% 75.24% +0.10%
==========================================
Files 362 363 +1
Lines 36282 36302 +20
==========================================
+ Hits 27262 27316 +54
+ Misses 6645 6618 -27
+ Partials 2375 2368 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 19 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
37f6c44
to
5d8c8f1
Compare
Basic implement the indepent (Tenant) TSO gPRC service. The kvproto pr is here pingcap/kvproto#1053 Signed-off-by: Bin Shi <[email protected]>
Adjust to the following two main changes in the gPRC protocol: 1.Add keyspace id and keyspace_group_id to RequestHeader/Response Header to support multi-tenant. 2.Define new XXXRequest/XXXResponse messages by reusing the messages in pdpb for better back-compatibility. The tenant tso protocol can also evolve independently by adding new rpcs and new messages. Signed-off-by: Bin Shi <[email protected]>
rebase master Signed-off-by: Bin Shi <[email protected]>
Signed-off-by: Bin Shi <[email protected]>
Signed-off-by: Bin Shi <[email protected]>
Signed-off-by: Bin Shi <[email protected]>
98f15f5
to
764b7ec
Compare
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949 Signed-off-by: Bin Shi <[email protected]>
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949 Signed-off-by: Bin Shi <[email protected]>
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949 Signed-off-by: Bin Shi <[email protected]>
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949 Signed-off-by: Bin Shi <[email protected]>
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949 Signed-off-by: Bin Shi <[email protected]>
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949 Signed-off-by: Bin Shi <[email protected]>
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949 Signed-off-by: Bin Shi <[email protected]>
This change is split from "basic implement tso gPRC service tikv#5949" tikv#5949 Signed-off-by: Bin Shi <[email protected]>
… microservice change (#5985) ref #5836, ref #5949 Refactor some common utilities which will be used by tso mcs Signed-off-by: Bin Shi <[email protected]>
@binshi-bing: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…n a basic manner (#5986) close #5836, ref #5949 Implement the server side of the tso grpc service. Signed-off-by: Bin Shi <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>
… microservice change (tikv#5985) ref tikv#5836, ref tikv#5949 Refactor some common utilities which will be used by tso mcs Signed-off-by: Bin Shi <[email protected]>
Shall we close it now? |
Broken down into separate prs. |
closed |
Signed-off-by: Bin Shi [email protected]
What problem does this PR solve?
Issue Number: Ref #5836
What is changed and how does it work?
Implement TSO gRPC service. We refactor and move tso rpcs' implementation from pd/server to pkg/tso so that both pd server and the independent TSO mcs can share the same tso logic layer and hide the internal data structures and logics from the upper layer. By doing so, we can adding multi-tenant and sharding while keep grpc layer stable.
Check List
Tests
Code changes
Side effects
Related changes
pingcap/docs
/pingcap/docs-cn
:pingcap/tiup
:Release note