Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

scheduler: move init function #5934

Merged
merged 3 commits into from
Feb 8, 2023
Merged

scheduler: move init function #5934

merged 3 commits into from
Feb 8, 2023

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Feb 7, 2023

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: Ref #5837

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@lhy1024
move init scheduler
f2c43f5 
Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 requested review from HunDunDM and rleungx February 7, 2023 15:26
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 7, 2023 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 7, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 7, 2023

cc @rleungx @binshi-bing

@lhy1024 lhy1024 added type/refactor The issue belongs to a refactor work. component/scheduler Scheduler logic. labels Feb 7, 2023
@lhy1024 lhy1024 mentioned this pull request Feb 7, 2023
Closed
12 tasks
@lhy1024
fix test
8b710b9 
Signed-off-by: lhy1024 <[email protected]>
@codecov
Copy link

codecov bot commented Feb 7, 2023 •
edited
Loading

Codecov Report

Base: 75.53% // Head: 75.53% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (9ba702a) compared to base (efa3e31).
Patch coverage: 59.61% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5934      +/-   ##
==========================================
- Coverage   75.53%   75.53%   -0.01%     
==========================================
  Files         345      346       +1     
  Lines       35132    35133       +1     
==========================================
  Hits        26538    26538              
- Misses       6304     6314      +10     
+ Partials     2290     2281       -9
Flag Coverage Δ
unittests 75.53% <59.61%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/balance_leader.go 88.38% <ø> (+1.37%) ⬆️
server/schedulers/balance_region.go 92.25% <ø> (+3.01%) ⬆️
server/schedulers/balance_witness.go 67.06% <ø> (+1.11%) ⬆️
server/schedulers/evict_leader.go 81.28% <ø> (+1.81%) ⬆️
server/schedulers/evict_slow_store.go 75.90% <ø> (+0.07%) ⬆️
server/schedulers/grant_hot_region.go 54.60% <ø> (+0.62%) ⬆️
server/schedulers/grant_leader.go 68.15% <ø> (+1.86%) ⬆️
server/schedulers/hot_region.go 85.00% <ø> (+0.43%) ⬆️
server/schedulers/label.go 70.00% <ø> (+2.14%) ⬆️
server/schedulers/random_merge.go 66.66% <ø> (+1.04%) ⬆️
... and 37 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

binshi-bing
binshi-bing approved these changes Feb 7, 2023
View reviewed changes
Copy link
Contributor

@binshi-bing binshi-bing left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Other alternatives might be Package plugin or k8s sidecar as the mid/long term solutions.

@ti-chi-bot
Copy link
Member

@binshi-bing: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM. Other alternatives might be Package plugin or k8s sidecar.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

binshi-bing
binshi-bing reviewed Feb 7, 2023
View reviewed changes
cmd/pd-server/main.go
@@ -136,6 +135,7 @@ func createServerWrapper(args []string) (context.Context, context.CancelFunc, ba
if err != nil {
log.Fatal("create server failed", errs.ZapError(err))
}
schedulers.Register()
Copy link
Contributor

@binshi-bing binshi-bing Feb 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other alternatives might be Package plugin or k8s sidecar as the mid/long term solutions.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 8, 2023
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Feb 8, 2023
@lhy1024
Copy link
Contributor Author

lhy1024 commented Feb 8, 2023

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 8b710b9

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 8, 2023
@ti-chi-bot ti-chi-bot merged commit 76c0c10 into tikv:master Feb 8, 2023
This was referenced Feb 8, 2023
Closed
Merged
Closed
@rleungx rleungx mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@binshi-bing binshi-bing binshi-bing approved these changes

@nolouch nolouch nolouch approved these changes

@rleungx rleungx rleungx approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

Assignees
No one assigned
Labels
component/scheduler Scheduler logic. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/refactor The issue belongs to a refactor work.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lhy1024 @ti-chi-bot @nolouch @rleungx @binshi-bing