scheduler: decreate the repeat filter in scheduler. #5544

bufferflies · 2022-09-22T08:58:02Z

What problem does this PR solve?

Issue Number: Close #5539

What is changed and how does it work?

Check List

Tests

Unit test
Integration test

Code changes

Side effects

Related changes

Release note

None.

ti-chi-bot · 2022-09-22T08:58:03Z

[REVIEW NOTIFICATION]

This pull request has been approved by:

CabinfeverB
rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: bufferflies <[email protected]>

codecov · 2022-09-23T11:13:30Z

Codecov Report

Base: 75.73% // Head: 75.82% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (a703fd6) compared to base (19aa1c8).
Patch coverage: 90.41% of modified lines in pull request are covered.

❗ Current head a703fd6 differs from pull request most recent head 324319a. Consider uploading reports for the commit 324319a to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5544      +/-   ##
==========================================
+ Coverage   75.73%   75.82%   +0.08%     
==========================================
  Files         326      326              
  Lines       32251    32276      +25     
==========================================
+ Hits        24425    24472      +47     
+ Misses       5720     5704      -16     
+ Partials     2106     2100       -6

Flag	Coverage Δ
unittests	`75.82% <90.41%> (+0.08%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/schedulers/metrics.go	`100.00% <ø> (ø)`
server/schedule/filter/filters.go	`91.05% <85.71%> (-0.22%)`	⬇️
server/schedulers/utils.go	`93.95% <87.50%> (-0.12%)`	⬇️
server/schedulers/balance_leader.go	`88.38% <100.00%> (+0.04%)`	⬆️
server/schedulers/balance_region.go	`88.88% <100.00%> (+1.64%)`	⬆️
pkg/metricutil/metricutil.go	`82.75% <0.00%> (-10.35%)`	⬇️
server/election/lease.go	`84.05% <0.00%> (-4.35%)`	⬇️
server/statistics/kind.go	`41.30% <0.00%> (-2.79%)`	⬇️
server/schedule/labeler/rules.go	`87.50% <0.00%> (-2.28%)`	⬇️
server/statistics/store_load.go	`96.22% <0.00%> (-1.80%)`	⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

server/core/store.go

server/schedulers/balance_region.go

server/schedulers/utils.go

Signed-off-by: bufferflies <[email protected]>

bufferflies · 2022-10-11T03:18:19Z

/check-issue-triage-complete

Signed-off-by: bufferflies <[email protected]>

CabinfeverB

Rest LGTM

server/schedulers/utils.go

server/schedulers/balance_region.go

CabinfeverB · 2022-10-14T08:58:58Z

I think the top score store will not have diagnostic info, I will test it.

server/schedule/filter/filters.go

server/schedulers/balance_test.go

rleungx · 2022-10-14T09:01:47Z

server/schedulers/utils.go

-		p.sourceScore = p.source.RegionScore(opts.GetRegionScoreFormulaVersion(), opts.GetHighSpaceRatio(), opts.GetLowSpaceRatio(), sourceDelta)
-		p.targetScore = p.target.RegionScore(opts.GetRegionScoreFormulaVersion(), opts.GetHighSpaceRatio(), opts.GetLowSpaceRatio(), targetDelta)
-	}
-	if opts.IsDebugMetricsEnabled() {


Is it deprecated?

No, I will add it again

Signed-off-by: bufferflies <[email protected]>

bufferflies · 2022-10-17T06:21:22Z

/ping， @CabinfeverB

bufferflies · 2022-10-18T03:09:28Z

/merge

ti-chi-bot · 2022-10-18T03:09:29Z

@bufferflies: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2022-10-18T03:09:31Z

This pull request has been accepted and is ready to merge.

Commit hash: a703fd6

ti-chi-bot · 2022-10-18T03:09:44Z

@bufferflies: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

) ref #5257, ref #5544 modify baseSchedulePlan to fit new balance region impl Signed-off-by: Cabinfever_B <[email protected]> Co-authored-by: Ti Chi Robot <[email protected]>

ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-triage-completed labels Sep 22, 2022

ti-chi-bot requested review from disksing and rleungx September 22, 2022 08:58

bufferflies mentioned this pull request Sep 22, 2022

schedulers: decrease target filter calculate #4080

Closed

bufferflies force-pushed the filter/once branch from dd6ed10 to 8c94c9c Compare September 22, 2022 11:46

bufferflies changed the title ~~draft: decreate the repeat filter in scheduler.~~ scheduler: decreate the repeat filter in scheduler. Sep 22, 2022

schedule filter once

6d1b5f7

Signed-off-by: bufferflies <[email protected]>

bufferflies force-pushed the filter/once branch from 3322a24 to 6d1b5f7 Compare September 23, 2022 10:49

pass unit test

3625728

Signed-off-by: bufferflies <[email protected]>

Merge branch 'master' into filter/once

1f64094

rleungx reviewed Sep 26, 2022

View reviewed changes

server/core/store.go Outdated Show resolved Hide resolved

server/schedulers/balance_region.go Show resolved Hide resolved

server/schedulers/utils.go Show resolved Hide resolved

bufferflies added 2 commits September 26, 2022 15:23

add more comment

4908692

Signed-off-by: bufferflies <[email protected]>

Merge branch 'filter/once' of github.com:bufferflies/pd into filter/once

9604315

ti-chi-bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed do-not-merge/needs-triage-completed labels Oct 11, 2022

update master

c05a469

Signed-off-by: bufferflies <[email protected]>

ti-chi-bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 11, 2022

filter once

4b98be7

Signed-off-by: bufferflies <[email protected]>

bufferflies force-pushed the filter/once branch from 4fe7ee9 to 4b98be7 Compare October 11, 2022 04:02

bufferflies requested a review from CabinfeverB October 11, 2022 07:50

filter once

4402d2f

Signed-off-by: bufferflies <[email protected]>

bufferflies force-pushed the filter/once branch from e6ab5af to 4402d2f Compare October 11, 2022 08:01

pass unit test

3e22c46

Signed-off-by: bufferflies <[email protected]>

CabinfeverB mentioned this pull request Oct 12, 2022

schdeuler: Set resource with step for collecting plan #5591

Merged

Merge branch 'master' into filter/once

621aa2d

bufferflies force-pushed the filter/once branch from 6b39ed0 to cb5c9b8 Compare October 14, 2022 03:09

using SetResourceWithStep

6c8218d

Signed-off-by: bufferflies <[email protected]>

bufferflies force-pushed the filter/once branch from cb5c9b8 to 6c8218d Compare October 14, 2022 03:27

CabinfeverB reviewed Oct 14, 2022

View reviewed changes

server/schedulers/utils.go Show resolved Hide resolved

server/schedulers/balance_region.go Show resolved Hide resolved

bufferflies requested a review from CabinfeverB October 14, 2022 08:11

rleungx reviewed Oct 14, 2022

View reviewed changes

bufferflies force-pushed the filter/once branch 2 times, most recently from 1634c71 to aec7752 Compare October 14, 2022 09:43

add comment

a703fd6

Signed-off-by: bufferflies <[email protected]>

bufferflies force-pushed the filter/once branch from aec7752 to a703fd6 Compare October 14, 2022 09:52

rleungx approved these changes Oct 14, 2022

View reviewed changes

ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Oct 14, 2022

CabinfeverB approved these changes Oct 17, 2022

View reviewed changes

ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Oct 17, 2022

ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 18, 2022

Merge branch 'master' into filter/once

324319a

ti-chi-bot merged commit 44e07e2 into tikv:master Oct 18, 2022

bufferflies deleted the filter/once branch October 18, 2022 06:14

CabinfeverB mentioned this pull request Oct 31, 2022

scheduler: modify baseSchedulePlan to fit new balance region impl #5614

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

scheduler: decreate the repeat filter in scheduler. #5544

scheduler: decreate the repeat filter in scheduler. #5544

bufferflies commented Sep 22, 2022 •

edited

Loading

ti-chi-bot commented Sep 22, 2022 •

edited

Loading

codecov bot commented Sep 23, 2022 •

edited

Loading

bufferflies commented Oct 11, 2022

CabinfeverB left a comment

CabinfeverB commented Oct 14, 2022

rleungx Oct 14, 2022

bufferflies Oct 14, 2022

bufferflies commented Oct 17, 2022

bufferflies commented Oct 18, 2022

ti-chi-bot commented Oct 18, 2022

ti-chi-bot commented Oct 18, 2022

ti-chi-bot commented Oct 18, 2022

scheduler: decreate the repeat filter in scheduler. #5544

scheduler: decreate the repeat filter in scheduler. #5544

Conversation

bufferflies commented Sep 22, 2022 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Check List

Release note

ti-chi-bot commented Sep 22, 2022 • edited Loading

codecov bot commented Sep 23, 2022 • edited Loading

Codecov Report

bufferflies commented Oct 11, 2022

CabinfeverB left a comment

Choose a reason for hiding this comment

CabinfeverB commented Oct 14, 2022

rleungx Oct 14, 2022

Choose a reason for hiding this comment

bufferflies Oct 14, 2022

Choose a reason for hiding this comment

bufferflies commented Oct 17, 2022

bufferflies commented Oct 18, 2022

ti-chi-bot commented Oct 18, 2022

ti-chi-bot commented Oct 18, 2022

ti-chi-bot commented Oct 18, 2022

bufferflies commented Sep 22, 2022 •

edited

Loading

ti-chi-bot commented Sep 22, 2022 •

edited

Loading

codecov bot commented Sep 23, 2022 •

edited

Loading