Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: move dim to statistics #5541

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

lhy1024
Copy link
Contributor

@lhy1024 lhy1024 commented Sep 22, 2022

Signed-off-by: lhy1024 [email protected]

What problem does this PR solve?

Issue Number: ref #4949

What is changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

Signed-off-by: lhy1024 <[email protected]>
@lhy1024 lhy1024 added the type/refactor The issue belongs to a refactor work. label Sep 22, 2022
@lhy1024 lhy1024 requested a review from HunDunDM September 22, 2022 07:01
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 22, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/needs-linked-issue release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/needs-linked-issue labels Sep 22, 2022
@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Base: 75.80% // Head: 75.61% // Decreases project coverage by -0.18% ⚠️

Coverage data is based on head (37627d6) compared to base (689dd56).
Patch coverage: 67.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5541      +/-   ##
==========================================
- Coverage   75.80%   75.61%   -0.19%     
==========================================
  Files         326      326              
  Lines       32265    32281      +16     
==========================================
- Hits        24458    24409      -49     
- Misses       5719     5767      +48     
- Partials     2088     2105      +17     
Flag Coverage Δ
unittests 75.61% <67.50%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/statistics/collector.go 93.75% <ø> (ø)
server/statistics/hot_peer.go 97.05% <ø> (ø)
server/statistics/kind.go 41.30% <33.33%> (-2.12%) ⬇️
server/schedulers/hot_region_v2.go 79.28% <80.00%> (-0.60%) ⬇️
server/schedulers/hot_region.go 85.53% <100.00%> (+0.24%) ⬆️
server/schedulers/hot_region_config.go 92.54% <100.00%> (ø)
tools/pd-ctl/pdctl/command/scheduler.go 75.61% <100.00%> (ø)
pkg/metricutil/metricutil.go 82.75% <0.00%> (-10.35%) ⬇️
server/schedulers/shuffle_hot_region.go 55.55% <0.00%> (-10.11%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-6.76%) ⬇️
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2022
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2022
@lhy1024
Copy link
Contributor Author

lhy1024 commented Sep 22, 2022

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 37627d6

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2022
@ti-chi-bot ti-chi-bot merged commit 8209515 into tikv:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/refactor The issue belongs to a refactor work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants