cluster: reset stores cache before loading cluster info (#4942)

[ti-chi-bot]

This is an automated cherry-pick of #4942

Signed-off-by: Ryan Leung [email protected]

What problem does this PR solve?

Issue Number: Close #4941.

What is changed and how does it work?

This PR resets the new leader store cache after transferring the PD leader.

Check List

Tests

• Unit test

Release note

Fix the issue that the removed tombstone store shows again after transferring the PD leader

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• lhy1024
• rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[rleungx]

/run-unit-tests

[rleungx]

/run-unit-tests

[rleungx]

/run-unit-tests

[codecov]

Codecov Report

Merging #4956 (3e37678) into release-5.1 (204ed42) will increase coverage by 0.13%.
The diff coverage is 80.00%.

❗ Current head 3e37678 differs from pull request most recent head 8cbd722. Consider uploading reports for the commit 8cbd722 to get more accurate results

@@               Coverage Diff               @@
##           release-5.1    #4956      +/-   ##
===============================================
+ Coverage        75.14%   75.27%   +0.13%     
===============================================
  Files              245      245              
  Lines            24784    24775       -9     
===============================================
+ Hits             18623    18650      +27     
+ Misses            4526     4504      -22     
+ Partials          1635     1621      -14     

Flag	Coverage Δ
unittests	75.27% <80.00%> (+0.13%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/cluster/cluster.go	82.66% <50.00%> (+0.52%)	⬆️
server/core/basic_cluster.go	90.90% <100.00%> (+0.18%)	⬆️
server/tso/tso.go	69.66% <0.00%> (-5.34%)	⬇️
server/region_syncer/client.go	78.90% <0.00%> (-0.79%)	⬇️
server/tso/allocator_manager.go	77.96% <0.00%> (-0.67%)	⬇️
server/schedule/checker/replica_strategy.go	88.37% <0.00%> (-0.52%)	⬇️
server/statistics/store_collection.go	93.70% <0.00%> (-0.05%)	⬇️
server/schedule/filter/candidates.go	100.00% <0.00%> (ø)
client/client.go	71.82% <0.00%> (+0.13%)	⬆️
server/schedule/checker/replica_checker.go	71.11% <0.00%> (+0.30%)	⬆️
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 204ed42...8cbd722. Read the comment docs.

[rleungx]

/merge

[ti-chi-bot]

@rleungx: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 3e37678

[ti-chi-bot]

@ti-chi-bot: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.