Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region_scatterer: fix incorrect test #4586

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Conversation

HunDunDM
Copy link
Member

What problem does this PR solve?

close #4583

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

None

@HunDunDM HunDunDM added the require-LGT1 Indicates that the PR requires an LGTM. label Jan 14, 2022
@HunDunDM HunDunDM requested review from nolouch and Yisaer January 14, 2022 10:19
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 14, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • JmPotato

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jan 14, 2022
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 14, 2022
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Jan 14, 2022
@JmPotato
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0462c60

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jan 14, 2022
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Jan 14, 2022
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Jan 14, 2022
HunDunDM added a commit to ti-chi-bot/pd that referenced this pull request Jan 14, 2022
@JmPotato
Copy link
Member

/run-unit-test

@HunDunDM HunDunDM added the needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. label Jan 14, 2022
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #4586 (0462c60) into master (32832a3) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4586      +/-   ##
==========================================
+ Coverage   74.83%   74.95%   +0.11%     
==========================================
  Files         265      265              
  Lines       27904    27908       +4     
==========================================
+ Hits        20883    20918      +35     
+ Misses       5154     5133      -21     
+ Partials     1867     1857      -10     
Flag Coverage Δ
unittests 74.95% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedule/region_scatterer.go 83.19% <100.00%> (+0.28%) ⬆️
server/region_syncer/server.go 81.41% <0.00%> (-5.13%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/region_syncer/client.go 78.90% <0.00%> (-4.69%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-1.18%) ⬇️
pkg/btree/btree.go 85.78% <0.00%> (-0.97%) ⬇️
server/server.go 71.85% <0.00%> (-0.90%) ⬇️
server/core/storage.go 69.31% <0.00%> (-0.76%) ⬇️
server/cluster/cluster.go 83.21% <0.00%> (-0.12%) ⬇️
server/tso/local_allocator.go 71.62% <0.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c31556a...0462c60. Read the comment docs.

@ti-chi-bot ti-chi-bot merged commit 6de5ffa into tikv:master Jan 14, 2022
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #4587.

@HunDunDM HunDunDM deleted the fix-4583 branch January 15, 2022 03:02
ti-chi-bot added a commit that referenced this pull request Jan 15, 2022
ti-chi-bot added a commit that referenced this pull request Jan 21, 2022
…ew peers (#4570) (#4579)

* region_scatterer: fix the bug that could generate schedule with too few peers (#4570)

close #4565

Signed-off-by: HunDunDM <[email protected]>

* region_scatterer: fix incorrect test (#4586)

Signed-off-by: HunDunDM <[email protected]>

Co-authored-by: HunDunDM <[email protected]>
disksing pushed a commit to oh-my-tidb/pd that referenced this pull request Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testScatterRegionSuite.TestScatterGroupInConcurrency is not stable
4 participants