-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
region_scatterer: fix incorrect test #4586
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 0462c60
|
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
/run-unit-test |
Codecov Report
@@ Coverage Diff @@
## master #4586 +/- ##
==========================================
+ Coverage 74.83% 74.95% +0.11%
==========================================
Files 265 265
Lines 27904 27908 +4
==========================================
+ Hits 20883 20918 +35
+ Misses 5154 5133 -21
+ Partials 1867 1857 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
In response to a cherrypick label: new pull request created: #4587. |
Signed-off-by: HunDunDM <[email protected]> Co-authored-by: HunDunDM <[email protected]>
…ew peers (#4570) (#4579) * region_scatterer: fix the bug that could generate schedule with too few peers (#4570) close #4565 Signed-off-by: HunDunDM <[email protected]> * region_scatterer: fix incorrect test (#4586) Signed-off-by: HunDunDM <[email protected]> Co-authored-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
What problem does this PR solve?
close #4583
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release note