-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
server: clone ReplicationModeConfig to avoid data race (#4343) #4370
server: clone ReplicationModeConfig to avoid data race (#4343) #4370
Conversation
close tikv#4325 Signed-off-by: disksing <[email protected]>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Codecov Report
@@ Coverage Diff @@
## release-5.3 #4370 +/- ##
===============================================
- Coverage 75.03% 74.90% -0.14%
===============================================
Files 264 264
Lines 27279 27279
===============================================
- Hits 20470 20433 -37
- Misses 5005 5034 +29
- Partials 1804 1812 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/merge |
@disksing: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 44530c4
|
This is an automated cherry-pick of #4343
Signed-off-by: disksing [email protected]
What problem does this PR solve?
close #4325
What is changed and how it works?
clone the config so it will be safe to update.
Check List
Release note