Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: clone ReplicationModeConfig to avoid data race (#4343) #4370

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4343

Signed-off-by: disksing [email protected]

What problem does this PR solve?

close #4325

What is changed and how it works?

clone the config so it will be safe to update.

Check List

  • Need to cherry-pick to the release branch

Release note

Fix data race when updating replication mode configuration

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Nov 23, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick. labels Nov 23, 2021
@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #4370 (77cfad4) into release-5.3 (31ad343) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.3    #4370      +/-   ##
===============================================
- Coverage        75.03%   74.90%   -0.14%     
===============================================
  Files              264      264              
  Lines            27279    27279              
===============================================
- Hits             20470    20433      -37     
- Misses            5005     5034      +29     
- Partials          1804     1812       +8     
Flag Coverage Δ
unittests 74.90% <100.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/server.go 71.85% <100.00%> (-0.15%) ⬇️
server/tso/local_allocator.go 64.86% <0.00%> (-13.52%) ⬇️
server/region_syncer/server.go 83.08% <0.00%> (-5.89%) ⬇️
server/tso/allocator_manager.go 64.16% <0.00%> (-4.50%) ⬇️
server/region_syncer/client.go 79.68% <0.00%> (-3.91%) ⬇️
server/tso/tso.go 63.63% <0.00%> (-1.71%) ⬇️
server/grpc_service.go 50.20% <0.00%> (-0.71%) ⬇️
client/client.go 71.44% <0.00%> (-0.58%) ⬇️
server/cluster/cluster.go 82.44% <0.00%> (-0.35%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31ad343...77cfad4. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 30, 2021
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 30, 2021
@disksing
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 44530c4

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Nov 30, 2021
@ti-chi-bot ti-chi-bot merged commit 70eddec into tikv:release-5.3 Nov 30, 2021
@purelind purelind added this to the v5.3.1 milestone Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. triage/accept type/cherry-pick-for-release-5.3 The PR belongs to release-5.3 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants