Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: update TiDB Dashboard to v2021.10.08.1 (#4189) #4184

Closed
wants to merge 2 commits into from

Conversation

shhdgit
Copy link
Contributor

@shhdgit shhdgit commented Sep 30, 2021

Signed-off-by: Suhaha [email protected]

This is an cherry-pick of #4189

What problem does this PR solve?

Update tidb-dashboard to v2021.10.08.1

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

Release note

Update tidb-dashboard to v2021.10.08.1

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added do-not-merge/cherry-pick-not-approved release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 30, 2021
@ti-chi-bot
Copy link
Member

@shhdgit: This cherry pick PR is for a release branch and has not yet been approved by release team.
Adding the do-not-merge/cherry-pick-not-approved label.

To merge this cherry pick, it must first be approved by the collaborators.

AFTER it has been approved by collaborators, please ping the release team in a comment to request a cherry pick review.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #4184 (d905935) into release-5.0 (a41aaa7) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head d905935 differs from pull request most recent head a72f836. Consider uploading reports for the commit a72f836 to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.0    #4184      +/-   ##
===============================================
+ Coverage        74.80%   74.89%   +0.09%     
===============================================
  Files              245      245              
  Lines            24323    24323              
===============================================
+ Hits             18194    18217      +23     
+ Misses            4516     4498      -18     
+ Partials          1613     1608       -5     
Flag Coverage Δ
unittests 74.89% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
client/base_client.go 82.47% <0.00%> (-2.07%) ⬇️
server/encryptionkm/key_manager.go 71.78% <0.00%> (-1.66%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-1.00%) ⬇️
pkg/btree/btree.go 85.30% <0.00%> (-0.97%) ⬇️
server/cluster/cluster.go 82.01% <0.00%> (-0.39%) ⬇️
server/server.go 72.43% <0.00%> (ø)
client/client.go 72.24% <0.00%> (+0.13%) ⬆️
server/grpc_service.go 47.17% <0.00%> (+0.45%) ⬆️
server/handler.go 42.46% <0.00%> (+0.49%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a41aaa7...a72f836. Read the comment docs.

@shhdgit shhdgit changed the title dashboard: update TiDB Dashboard to v2021.09.27.1 (#4177) dashboard: update TiDB Dashboard to v2021.10.08.1 (#4177) Oct 8, 2021
@ti-chi-bot ti-chi-bot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 8, 2021
@shhdgit shhdgit changed the title dashboard: update TiDB Dashboard to v2021.10.08.1 (#4177) dashboard: update TiDB Dashboard to v2021.10.08.1 (#4189) Oct 8, 2021
@shhdgit shhdgit marked this pull request as draft October 29, 2021 02:09
@ti-chi-bot ti-chi-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 29, 2021
@shhdgit shhdgit closed this Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/cherry-pick-not-approved do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants