Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: dynamically adjust the retry limit according to the operator (#4007) #4046

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #4007

Signed-off-by: HunDunDM [email protected]

What problem does this PR solve?

related #3744

What is changed and how it works?

  • scheduler: dynamically adjust the retry limit according to the operator

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

None

@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • disksing

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov
Copy link

codecov bot commented Aug 29, 2021

Codecov Report

Merging #4046 (fa778b4) into release-5.2 (6f3ff3f) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.2    #4046      +/-   ##
===============================================
+ Coverage        74.69%   74.81%   +0.11%     
===============================================
  Files              249      249              
  Lines            25550    25582      +32     
===============================================
+ Hits             19084    19138      +54     
+ Misses            4784     4763      -21     
+ Partials          1682     1681       -1     
Flag Coverage Δ
unittests 74.81% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/balance_leader.go 91.55% <100.00%> (+0.46%) ⬆️
server/schedulers/balance_region.go 89.16% <100.00%> (+0.47%) ⬆️
server/schedulers/utils.go 94.75% <100.00%> (+0.29%) ⬆️
server/statistics/hot_cache_task.go 75.00% <0.00%> (-4.17%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/schedulers/random_merge.go 60.00% <0.00%> (-3.34%) ⬇️
server/election/lease.go 94.91% <0.00%> (-1.70%) ⬇️
server/tso/tso.go 60.22% <0.00%> (-1.66%) ⬇️
server/grpc_service.go 47.45% <0.00%> (-0.23%) ⬇️
client/client.go 71.82% <0.00%> (-0.14%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f3ff3f...fa778b4. Read the comment docs.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 30, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 31, 2021
Signed-off-by: HunDunDM <[email protected]>
@HunDunDM HunDunDM force-pushed the cherry-pick-4007-to-release-5.2 branch from ef6cdc9 to 8cba363 Compare August 31, 2021 07:00
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Oct 12, 2021
@nolouch
Copy link
Contributor

nolouch commented Oct 13, 2021

/merge

@ti-chi-bot
Copy link
Member Author

@nolouch: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 8cba363

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. release-note-none Denotes a PR that doesn't merit a release note. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.2 The PR belongs to release-5.2 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants