Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

region_syncer: reduce saveKV of client (#3808) #3933

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #3808

What problem does this PR solve?

What is changed and how it works?

  • By introducing part of the heartbeat processing logic in the client of region_syncer, unnecessary saveKV operations are reduced.

Check List

Tests

  • Unit test

Code changes

Side effects

Related changes

Release note

Improved the performance of synchronizing Region information between PDs.

Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
Signed-off-by: HunDunDM <[email protected]>
@ti-chi-bot
Copy link
Member Author

ti-chi-bot commented Aug 2, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM
  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/cherry-pick-not-approved component/cluster Cluster logic. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick. labels Aug 2, 2021
@ti-chi-bot ti-chi-bot requested review from HunDunDM and Yisaer August 2, 2021 05:24
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #3933 (cc28564) into release-5.1 (59693ab) will increase coverage by 0.04%.
The diff coverage is 92.50%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-5.1    #3933      +/-   ##
===============================================
+ Coverage        75.08%   75.13%   +0.04%     
===============================================
  Files              245      245              
  Lines            24614    24634      +20     
===============================================
+ Hits             18482    18508      +26     
+ Misses            4513     4506       -7     
- Partials          1619     1620       +1     
Flag Coverage Δ
unittests 75.13% <92.50%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/region_syncer/client.go 81.69% <78.57%> (-1.02%) ⬇️
server/region_syncer/server.go 88.97% <83.33%> (+5.63%) ⬆️
server/core/region.go 91.20% <96.61%> (+0.78%) ⬆️
server/cluster/cluster.go 82.39% <100.00%> (-0.49%) ⬇️
pkg/etcdutil/etcdutil.go 84.70% <0.00%> (-3.53%) ⬇️
server/member/member.go 65.59% <0.00%> (-3.23%) ⬇️
pkg/dashboard/adapter/manager.go 79.78% <0.00%> (-3.20%) ⬇️
server/schedule/operator/step.go 67.44% <0.00%> (-1.67%) ⬇️
server/encryptionkm/key_manager.go 71.78% <0.00%> (-1.66%) ⬇️
server/server.go 71.58% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59693ab...cc28564. Read the comment docs.

@HunDunDM HunDunDM added this to the v5.1.2 milestone Aug 11, 2021
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Sep 13, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 13, 2021
@HunDunDM
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member Author

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: cc28564

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 13, 2021
@ti-chi-bot ti-chi-bot merged commit 2d1a00a into tikv:release-5.1 Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/cluster Cluster logic. release-note Denotes a PR that will be considered when it comes time to generate release notes. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/cherry-pick-for-release-5.1 The PR belongs to release-5.1 cherry pick.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants