schedulers: rollback the scheduler when failing to persist (#3787)

[ti-chi-bot]

This is an automated cherry-pick of #3787

What problem does this PR solve?

Try to fix #2572.

What is changed and how it works?

This PR corrects the status code and rollback the scheduler when failing to persist.

Check List

Tests

• Unit test

Related changes

• Need to cherry-pick to the release branch

Release note

Fix the issue that the scheduler may appear again even if we have already executed the delete operation

[ti-chi-bot]

[REVIEW NOTIFICATION]

This pull request has been approved by:

• HunDunDM
• lhy1024

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

[HunDunDM]

/merge

[ti-chi-bot]

@HunDunDM: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

This pull request has been accepted and is ready to merge.

Commit hash: 41523aa

[codecov]

Codecov Report

Merging #3823 (41523aa) into release-5.0 (09e8392) will decrease coverage by 0.04%.
The diff coverage is 79.01%.

@@               Coverage Diff               @@
##           release-5.0    #3823      +/-   ##
===============================================
- Coverage        74.73%   74.68%   -0.05%     
===============================================
  Files              245      245              
  Lines            24188    24241      +53     
===============================================
+ Hits             18076    18104      +28     
- Misses            4503     4523      +20     
- Partials          1609     1614       +5     

Flag	Coverage Δ
unittests	74.68% <79.01%> (-0.05%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
server/api/scheduler.go	45.40% <42.85%> (+0.76%)	⬆️
server/schedulers/grant_leader.go	66.66% <50.00%> (-1.69%)	⬇️
server/cluster/coordinator.go	75.17% <66.66%> (+0.89%)	⬆️
server/schedulers/evict_leader.go	74.37% <88.88%> (+5.86%)	⬆️
server/api/region.go	65.84% <96.15%> (+1.66%)	⬆️
server/config/persist_options.go	91.43% <100.00%> (+0.10%)	⬆️
tests/pdctl/helper.go	100.00% <100.00%> (ø)
server/tso/local_allocator.go	73.61% <0.00%> (-6.95%)	⬇️
server/tso/tso.go	69.93% <0.00%> (-4.30%)	⬇️
server/election/leadership.go	83.52% <0.00%> (-3.53%)	⬇️
... and 13 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f28edc8...41523aa. Read the comment docs.