Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: Update TiDB Dashboard to v2021.06.15.1 #3785

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

shhdgit
Copy link
Contributor

@shhdgit shhdgit commented Jun 16, 2021

Signed-off-by: Suhaha [email protected]

What problem does this PR solve?

Update to TiDB Dashboard v2021.06.15.1

What is changed and how it works?

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Related changes

  • Need to cherry-pick to the release branch

Release note

Update TiDB Dashboard to v2021.06.15.1

@ti-chi-bot ti-chi-bot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jun 16, 2021
@ti-chi-bot ti-chi-bot requested review from nolouch and rleungx June 16, 2021 12:39
@codecov
Copy link

codecov bot commented Jun 16, 2021

Codecov Report

Merging #3785 (ed97b63) into master (2cc069f) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
+ Coverage   75.10%   75.12%   +0.02%     
==========================================
  Files         245      245              
  Lines       24597    24597              
==========================================
+ Hits        18474    18479       +5     
  Misses       4500     4500              
+ Partials     1623     1618       -5     
Flag Coverage Δ
unittests 75.12% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/tempurl/tempurl.go 45.00% <0.00%> (-15.00%) ⬇️
server/schedulers/shuffle_hot_region.go 54.73% <0.00%> (-9.48%) ⬇️
server/region_syncer/server.go 83.33% <0.00%> (-6.07%) ⬇️
server/id/id.go 76.19% <0.00%> (-4.77%) ⬇️
server/cluster/cluster.go 82.94% <0.00%> (-0.82%) ⬇️
server/core/storage.go 67.68% <0.00%> (-0.77%) ⬇️
server/cluster/coordinator.go 72.51% <0.00%> (-0.72%) ⬇️
server/server.go 71.62% <0.00%> (-0.46%) ⬇️
server/grpc_service.go 48.34% <0.00%> (+0.22%) ⬆️
server/tso/allocator_manager.go 81.46% <0.00%> (+0.83%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2cc069f...ed97b63. Read the comment docs.

@shhdgit shhdgit force-pushed the update-dashboard/0615 branch 3 times, most recently from 69a15c7 to 84745a0 Compare June 16, 2021 15:14
@shhdgit shhdgit force-pushed the update-dashboard/0615 branch from 84745a0 to eda2ed0 Compare June 16, 2021 15:17
@ti-chi-bot
Copy link
Member

@breeswish: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@breezewish breezewish added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 labels Jun 16, 2021
@breezewish
Copy link
Member

@HunDunDM PTAL, thanks!

@HunDunDM HunDunDM changed the title dashboard: Update to TiDB Dashboard v2021.06.15.1 dashboard: Update TiDB Dashboard to v2021.06.15.1 Jun 16, 2021
@ti-chi-bot ti-chi-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 16, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • HunDunDM

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 16, 2021
@HunDunDM HunDunDM added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 16, 2021
@breezewish
Copy link
Member

/merge

@ti-chi-bot
Copy link
Member

@breeswish: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@breeswish: /merge is only allowed for the committers, you can assign this pull request to the committer in list by filling /assign @committer in the comment to help merge this pull request.

In response to this:

/merge

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@lhy1024
Copy link
Contributor

lhy1024 commented Jun 17, 2021

/merge

@ti-chi-bot
Copy link
Member

@lhy1024: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: ed97b63

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 17, 2021
@breezewish
Copy link
Member

/run-integration-common-test

@ti-chi-bot ti-chi-bot merged commit ae91b18 into tikv:master Jun 17, 2021
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3793.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Jun 17, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3794.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #3795.

ti-chi-bot added a commit that referenced this pull request Jun 25, 2021
* This is an automated cherry-pick of #3785

Signed-off-by: ti-chi-bot <[email protected]>

* Resolve conflict

Signed-off-by: Suhaha <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
Co-authored-by: ShuNing <[email protected]>
ti-chi-bot added a commit that referenced this pull request Jul 6, 2021
* This is an automated cherry-pick of #3785

Signed-off-by: ti-chi-bot <[email protected]>

* Resolve conflict

Signed-off-by: Suhaha <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>
bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
bufferflies pushed a commit to bufferflies/pd that referenced this pull request Jul 9, 2021
@shhdgit shhdgit deleted the update-dashboard/0615 branch September 2, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-5.0 The PR needs to cherry pick to release-5.0 branch. needs-cherry-pick-release-5.1 Type: Need cherry pick to release-5.1 release-note Denotes a PR that will be considered when it comes time to generate release notes. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants