Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scheduler: fix scatter range scheduler limit (#3361) #3402

Merged

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jan 28, 2021

cherry-pick #3361 to release-5.0-rc
You can switch your code base to this Pull Request by using git-extras:

# In pd repo:
git pr https://github.com/tikv/pd/pull/3402

After apply modifications, you can push your change to this PR via:

git push [email protected]:ti-srebot/pd.git pr/3402:release-5.0-rc-680a3a48d3cd

What problem does this PR solve?

Closes #3356

What is changed and how it works?

This PR fixes the limit constriction for scatter range scheduler.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Fix the limit constriction of the scatter range scheduler

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-srebot
Copy link
Contributor Author

@rleungx you're already a collaborator in bot's repo.

@rleungx rleungx requested a review from lhy1024 January 29, 2021 07:04
@rleungx rleungx force-pushed the release-5.0-rc-680a3a48d3cd branch from d2a21c7 to 4553dd5 Compare January 29, 2021 07:10
@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

Merging #3402 (4553dd5) into release-5.0-rc (f4e7924) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-5.0-rc    #3402      +/-   ##
==================================================
- Coverage           74.12%   74.11%   -0.01%     
==================================================
  Files                 243      243              
  Lines               23088    23093       +5     
==================================================
+ Hits                17113    17116       +3     
  Misses               4401     4401              
- Partials             1574     1576       +2     
Flag Coverage Δ
unittests 74.11% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/schedulers/scatter_range.go 81.37% <100.00%> (+0.66%) ⬆️
server/election/lease.go 89.83% <0.00%> (-3.39%) ⬇️
server/encryptionkm/key_manager.go 71.78% <0.00%> (-1.66%) ⬇️
server/election/leadership.go 80.48% <0.00%> (-1.22%) ⬇️
server/tso/allocator_manager.go 75.00% <0.00%> (-0.81%) ⬇️
server/grpc_service.go 55.99% <0.00%> (-0.69%) ⬇️
server/tso/tso.go 78.61% <0.00%> (-0.63%) ⬇️
server/member/member.go 67.93% <0.00%> (-0.55%) ⬇️
server/server.go 73.25% <0.00%> (-0.48%) ⬇️
server/cluster/cluster.go 80.88% <0.00%> (+0.50%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4e7924...4553dd5. Read the comment docs.

@lhy1024 lhy1024 added this to the v5.0.0-rc.1 milestone Feb 1, 2021
@Yisaer
Copy link
Contributor

Yisaer commented Feb 1, 2021

/merge

@ti-chi-bot
Copy link
Member

@Yisaer: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 4553dd5

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 1, 2021
@rleungx
Copy link
Member

rleungx commented Feb 2, 2021

/run-all-tests

@ti-chi-bot ti-chi-bot merged commit a8ae117 into tikv:release-5.0-rc Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/scheduler Scheduler logic. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants