schedule: add some operator steps related to joint consensus #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yisaer
reviewed
Sep 7, 2020
rleungx
reviewed
Sep 7, 2020
Yisaer
reviewed
Sep 7, 2020
| peer := region.GetStoreVoter(pl.ToStore) | ||
| if peer == nil || peer.Id != pl.PeerID || | ||
| (peer.Role != metapb.PeerRole_IncomingVoter && peer.Role != metapb.PeerRole_Voter) { | ||
| return 0 |
There was a problem hiding this comment.
What about adding a log here?
There was a problem hiding this comment.
This function will be executed repeatedly, and no error occurs here. What information needs to be logged here?
disksing
reviewed
Sep 7, 2020
server/schedule/operator/step.go
Outdated
| (notInJointState && count != 0) || | ||
| (inJointState && count != len(cpe.PromoteLearners)+len(cpe.DemoteVoters)) { | ||
| // change is not atomic, or there are other peers in the joint state | ||
| return errors.New("unexpected peer role") |
There was a problem hiding this comment.
better to add more detail, or we cannot know which condition fail
There was a problem hiding this comment.
Different error messages have been returned for different situations. PTAL
HunDunDM
changed the title
Signed-off-by: Zheng Xiangsheng <[email protected]>
HunDunDM
force-pushed
the
joint/steps
branch
from
865bd14 to
16c8095
Compare
HunDunDM
changed the title
Signed-off-by: Zheng Xiangsheng <[email protected]>
HunDunDM
commented
Sep 8, 2020
Yisaer
reviewed
Sep 9, 2020
Yisaer
reviewed
Sep 9, 2020
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
disksing
approved these changes
Sep 9, 2020
ti-srebot
approved these changes
Sep 9, 2020
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@HunDunDM merge failed. |
|
/run-integration-lightning-test |
HunDunDM
added a commit
to HunDunDM/pd
that referenced
this pull request
Sep 16, 2020
* schedule: add some operator steps related to joint consensus Signed-off-by: Zheng Xiangsheng <[email protected]> * refine errors Signed-off-by: Zheng Xiangsheng <[email protected]> * rename Signed-off-by: Zheng Xiangsheng <[email protected]> * address comment Signed-off-by: Zheng Xiangsheng <[email protected]> Co-authored-by: ti-srebot <[email protected]> Signed-off-by: Zheng Xiangsheng <[email protected]> # Conflicts: # server/schedule/operator_controller.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zheng Xiangsheng [email protected]
What problem does this PR solve?
This is a child PR of #2886
For details, please refer to #2860
What is changed and how it works?
DemoteFollowerChangePeerV2EnterandChangePeerVLeavewith a sub-stepDemoteVoterConfVerChangedfrombooltouint64ConfVerChangedbehavior ofRemovePeer:PeerIDis specified, ifPeerIDis changed, it is also regarded asConfVerChanged = 1Check List
Tests
Release note