scheduler: filter unhealthy store in summaryStoresLoad (#2737) #2805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ti-srebot
requested review from
disksing,
HunDunDM,
nolouch,
rleungx,
sunzhuohang and
Yisaer
lhy1024
approved these changes
Aug 20, 2020
Codecov Report
@@ Coverage Diff @@
## release-4.0 #2805 +/- ##
===============================================
+ Coverage 77.16% 77.58% +0.41%
===============================================
Files 204 206 +2
Lines 21940 22676 +736
===============================================
+ Hits 16931 17593 +662
- Misses 3724 3773 +49
- Partials 1285 1310 +25
Continue to review full report at Codecov.
|
|
/run-all-tests |
Signed-off-by: lhy1024 <[email protected]> (cherry picked from commit 3a4cae5)
Signed-off-by: lhy1024 <[email protected]> (cherry picked from commit 72a7ee3)
lhy1024
force-pushed
the
release-4.0-3a4cae5a3370
branch
from
96722fd to
2c48fe5
Compare
|
/run-all-tests |
|
LGTM |
ti-srebot
added
status/LGT2
|
/merge |
nolouch
approved these changes
Aug 21, 2020
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/merge |
|
/run-all-tests |
|
/merge |
1 similar comment
|
/merge |
|
@ti-srebot merge failed. |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-all-tests |
|
@ti-srebot merge failed. |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #2737 to release-4.0
Signed-off-by: lhy1024 [email protected]
What problem does this PR solve?
Before this PR, we have not filtered unhealthy store in
summaryStoresLoad, it will make exp to be inaccurateWhat is changed and how it works?
Fix it
Check List
Tests
Release note
summaryStoresLoad