Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kvproto in dependencies #2729

Merged
merged 8 commits into from
Aug 13, 2020
Merged

Conversation

HunDunDM
Copy link
Member

@HunDunDM HunDunDM commented Aug 6, 2020

What problem does this PR solve?

  • Update kvproto to develop JointConsensus

What is changed and how it works?

  • Update kvproto: wait for kvproto/pull/658
  • Compatible with the change from IsLearner to Role.

Check List

Tests

  • Unit test

Release note

Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
@HunDunDM HunDunDM force-pushed the use-joint-consensus branch from 3eed3a8 to 34ebc85 Compare August 7, 2020 08:46
@HunDunDM HunDunDM changed the title Use joint consensus Update kvproto in dependencies Aug 7, 2020
@HunDunDM HunDunDM marked this pull request as ready for review August 7, 2020 09:00
@HunDunDM HunDunDM self-assigned this Aug 7, 2020
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
pkg/metautil/peer.go Outdated Show resolved Hide resolved
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: Zheng Xiangsheng <[email protected]>
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2020
@HunDunDM
Copy link
Member Author

/run-all-tests

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Aug 13, 2020
@disksing
Copy link
Contributor

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit b0128cd into tikv:master Aug 13, 2020
@HunDunDM HunDunDM deleted the use-joint-consensus branch August 13, 2020 08:29
disksing pushed a commit to oh-my-tidb/pd that referenced this pull request Aug 19, 2020
ZenoTan pushed a commit to ZenoTan/pd that referenced this pull request Aug 24, 2020
Signed-off-by: Zheng Xiangsheng <[email protected]>
Signed-off-by: ZenoTan <[email protected]>
jyz0309 pushed a commit to jyz0309/pd that referenced this pull request Aug 24, 2020
jyz0309 pushed a commit to jyz0309/pd that referenced this pull request Aug 24, 2020
@HunDunDM HunDunDM mentioned this pull request Sep 2, 2020
37 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants