rule: let default rule fit the region at last #2626
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Given region and store with following status:
Then post a rule like following:
Then label store 1 as "role": "leader"
The expected RegionFit is:
For rule "test", the peers are peer-1 in store 1
For rule "pd", the peers are [peer-2,peer-3,peer-4] in store2/3/4
What we got is:
For rule "test", the peers are empty.
For rule "pd", the peers are [peer-1,peer-2,peer-3] in store 1/2/3
What is changed and how it works?
One possible solution is to let default rule fit the region at last.
Check List
Tests
Release note