Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: check the timeout for creating stream #2616

Merged
merged 4 commits into from
Jul 14, 2020
Merged

client: check the timeout for creating stream #2616

merged 4 commits into from
Jul 14, 2020

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Jul 8, 2020 •
edited
Loading

What problem does this PR solve?

Closes #2642.

What is changed and how it works?

This PR uses an extra goroutine to check if creating stream causes too much time and will call cancel once it reaches the timeout setting of the client.

Check List

Tests

  • TODO

Release note

@rleungx rleungx requested review from disksing and HunDunDM July 8, 2020 11:24
@rleungx rleungx added the component/client Client logic. label Jul 8, 2020
disksing
disksing approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@disksing disksing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can add some test?

Yisaer
Yisaer approved these changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nolouch
Copy link
Contributor

nolouch commented Jul 10, 2020

/merge

@ti-srebot
Copy link
Contributor

Sorry @nolouch, you don't have permission to trigger auto merge event on this branch. The number of LGTM for this PR is 0 while it needs 2 at least

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 10, 2020

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

@lhy1024,Thanks for your review.

@lhy1024 lhy1024 added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 10, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Jul 10, 2020

/merge

@ti-srebot
Copy link
Contributor

Sorry @lhy1024, you don't have permission to trigger auto merge event on this branch. The number of LGTM for this PR is 1 while it needs 2 at least

@lhy1024 lhy1024 added require-LGT1 Indicates that the PR requires an LGTM. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Jul 10, 2020
@lhy1024
Copy link
Contributor

lhy1024 commented Jul 10, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 10, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 10, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 13, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@rleungx merge failed.

@lhy1024
Copy link
Contributor

lhy1024 commented Jul 14, 2020

/merge

@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 4318313 into tikv:master Jul 14, 2020
@disksing
Copy link
Contributor

@rleungx Did you send PR to update TiDB dependency?

@rleungx rleungx added needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. labels Jul 15, 2020
@rleungx
Copy link
Member Author

rleungx commented Jul 15, 2020

/run-cherry-picker

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

@rleungx
Copy link
Member Author

rleungx commented Jul 15, 2020

@rleungx Did you send PR to update TiDB dependency?

I will update it.

@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 failed

1 similar comment
@ti-srebot
Copy link
Contributor

cherry pick to release-3.0 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-3.1 failed

@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 failed

rleungx added a commit to rleungx/pd that referenced this pull request Jul 15, 2020
@rleungx
client: check the timeout for creating stream (tikv#2616)
b284107 
Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx mentioned this pull request Jul 15, 2020
Merged
disksing pushed a commit that referenced this pull request Jul 15, 2020
@rleungx
client: check the timeout for creating stream (#2616) (#2648)
ae0b004 
Signed-off-by: Ryan Leung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disksing disksing disksing approved these changes

@Yisaer Yisaer Yisaer approved these changes

@lhy1024 lhy1024 lhy1024 approved these changes

@HunDunDM HunDunDM Awaiting requested review from HunDunDM

Assignees
No one assigned
Labels
component/client Client logic. needs-cherry-pick-release-3.0 The PR needs to cherry pick to release-3.0 branch. needs-cherry-pick-release-3.1 The PR needs to cherry pick to release-3.1 branch. needs-cherry-pick-release-4.0 The PR needs to cherry pick to release-4.0 branch. require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create tso stream without timeout may block for a while
6 participants
@rleungx @nolouch @ti-srebot @lhy1024 @disksing @Yisaer