Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can etcd Election speed up leader failover #76

Closed
siddontang opened this issue Apr 15, 2016 · 3 comments
Closed

can etcd Election speed up leader failover #76

siddontang opened this issue Apr 15, 2016 · 3 comments
Assignees

Comments

@siddontang
Copy link
Contributor

https://github.com/coreos/etcd/blob/master/clientv3/concurrency/election.go

@siddontang
Copy link
Contributor Author

I see etcd Election use session timeout https://github.com/coreos/etcd/blob/master/clientv3/concurrency/election.go#L53, so it will wait at lease 60s to re-elect again if current leader was down, this is too long for us.

Maybe we should think another way to speed up it, and the client must handle this scenario carefully too.

@qiuyesuifeng
Copy link
Contributor

We use watch for leader failover on etcd, it costs about five seconds to handle it, so i think it is OK now.
@siddontang What is your opinion? Can this issue be closed?

@siddontang
Copy link
Contributor Author

@xiang90 told me before that he would try to speed up in test, does it support now? If not, we can close it.

rleungx added a commit to rleungx/pd that referenced this issue Jun 5, 2023
* fix tso inconsistent problem

Signed-off-by: Ryan Leung <[email protected]>

* *: fix the missing log panic (tikv#6325)

close tikv#6257

Signed-off-by: Ryan Leung <[email protected]>

* *: add defer to logs the panic reason and stack (tikv#6123)

ref tikv#6099

add defer logs the panic reason and stack

Signed-off-by: husharp <[email protected]>

Co-authored-by: Ti Chi Robot <[email protected]>

---------

Signed-off-by: Ryan Leung <[email protected]>
Co-authored-by: Hu# <[email protected]>
Co-authored-by: Ti Chi Robot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants