Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor ServicePath function of mcs/discovery package #6800

Closed
sunxiaoguang opened this issue Jul 13, 2023 · 0 comments · Fixed by #6799
Closed

Refactor ServicePath function of mcs/discovery package #6800

sunxiaoguang opened this issue Jul 13, 2023 · 0 comments · Fixed by #6799
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@sunxiaoguang
Copy link
Member

sunxiaoguang commented Jul 13, 2023 •
edited
Loading

Enhancement Task

All callers of ServicePath had to manually append a tailing slash which is tedious and error prone.
@sunxiaoguang sunxiaoguang added the type/enhancement The issue or PR belongs to an enhancement. label Jul 13, 2023
@sunxiaoguang sunxiaoguang mentioned this issue Jul 13, 2023
Merged
ti-chi-bot bot added a commit that referenced this issue Jul 14, 2023
@sunxiaoguang @ti-chi-bot
mcs: Refactor ServicePath to make caller's life easier (#6799)
a621fcb 
close #6800

Signed-off-by: Xiaoguang Sun <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
rleungx pushed a commit to rleungx/pd that referenced this issue Aug 2, 2023
@sunxiaoguang @ti-chi-bot @rleungx
mcs: Refactor ServicePath to make caller's life easier (tikv#6799)
6ae87bf 
close tikv#6800

Signed-off-by: Xiaoguang Sun <[email protected]>

Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

mcs: Refactor ServicePath to make caller's life easier sunxiaoguang/pd
1 participant
@sunxiaoguang