Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tikv read only label is lost after tikv restart #6467

Closed
Lily2025 opened this issue May 15, 2023 · 1 comment · Fixed by #6468
Closed

tikv read only label is lost after tikv restart #6467

Lily2025 opened this issue May 15, 2023 · 1 comment · Fixed by #6468
Assignees
@JmPotato
Labels
affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/critical type/bug The issue is confirmed as a bug.

Comments

@Lily2025
Copy link

Bug Report

What did you do?

rolling restart tikv

What did you expect to see?

tikv read only label is not lost

What did you see instead?

tikv read only label is lost after tikv restart
image

What version of PD are you using (pd-server -V)?

/ # ./pd-server -V
Release Version: v6.5.1
Edition: Community
Git Commit Hash: bd80719
Git Branch: heads/refs/tags/v6.5.1
UTC Build Time: 2023-03-09 10:57:50
@Lily2025 Lily2025 added the type/bug The issue is confirmed as a bug. label May 15, 2023
@Lily2025
Copy link
Author

/type bug
/severity critical

@JmPotato JmPotato self-assigned this May 15, 2023
@JmPotato JmPotato mentioned this issue May 15, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 15, 2023
@JmPotato
cluster: fix the merging issue of labels after store reboot (#6468)
30f78a5 
ref #5510, close #6467

#5510 introduced a bug that would cause the store labels to be overwritten wrongly after the store reboot.
This PR fixed this issue.

Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue May 15, 2023
Merged
ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this issue May 15, 2023
@JmPotato @ti-chi-bot
This is an automated cherry-pick of tikv#6468
234c928 
ref tikv#5510, close tikv#6467

Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this issue May 15, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this issue May 15, 2023
@ti-chi-bot @JmPotato
cluster: fix the merging issue of labels after store reboot (#6468) (#…
dbfbdac 
…6470)

ref #5510, close #6467, ref #6468

#5510 introduced a bug that would cause the store labels to be overwritten wrongly after the store reboot.
This PR fixed this issue.

Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
ti-chi-bot bot pushed a commit that referenced this issue May 15, 2023
@ti-chi-bot @JmPotato
cluster: fix the merging issue of labels after store reboot (#6468) (#…
c7db3b3 
…6469)

ref #5510, close #6467, ref #6468

#5510 introduced a bug that would cause the store labels to be overwritten wrongly after the store reboot.
This PR fixed this issue.

Signed-off-by: ti-chi-bot <[email protected]>
Signed-off-by: JmPotato <[email protected]>

Co-authored-by: JmPotato <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JmPotato JmPotato

Labels
affects-6.4 affects-6.5 This bug affects the 6.5.x(LTS) versions. affects-6.6 affects-7.0 affects-7.1 This bug affects the 7.1.x(LTS) versions. severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cluster: fix the merging issue of labels after store reboot JmPotato/pd
2 participants
@JmPotato @Lily2025