Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linter panic after upgrade to Go1.18 #4944

Closed
nolouch opened this issue May 13, 2022 · 0 comments · Fixed by #4945
Closed

Linter panic after upgrade to Go1.18 #4944

nolouch opened this issue May 13, 2022 · 0 comments · Fixed by #4945
Labels
severity/minor type/bug The issue is confirmed as a bug.

Comments

@nolouch
Copy link
Contributor

nolouch commented May 13, 2022

Bug Report

What did you do?

Linter panic after upgrade to Go1.18

What did you expect to see?

work fine

What did you see instead?

panic cannot import fmt.

gofmt ...
golangci-lint ...
panic: load embedded ruleguard rules: rules/rules.go:13: can't load fmt

What version of PD are you using (pd-server -V)?

master
@nolouch nolouch added the type/bug The issue is confirmed as a bug. label May 13, 2022
@nolouch nolouch mentioned this issue May 13, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue May 13, 2022
@nolouch
*: Fix linter after Go 1.18 upgrade (#4945)
dd8d0b0 
close #4944, ref #4944

Signed-off-by: nolouch <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: Fix linter after Go 1.18 upgrade nolouch/pd
1 participant
@nolouch